From caec464d67d684ab45f8b3cc50c7ee218da4000a Mon Sep 17 00:00:00 2001 From: Alan Coopersmith Date: Tue, 19 Aug 2025 18:52:16 -0700 Subject: [PATCH] dix: Fix builds with meson -Dxace=false -Dwerror=true MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CI meson-disable-options builds were failing with: ../dix/events.c: In function ‘CoreEnterLeaveEvent’: ../dix/events.c:4723:19: error: unused variable ‘client’ [-Werror=unused-variable] 4723 | ClientPtr client = grab ? rClient(grab) : wClient(pWin); | ^~~~~~ ../dix/events.c: In function ‘CoreFocusEvent’: ../dix/events.c:4834:19: error: unused variable ‘client’ [-Werror=unused-variable] 4834 | ClientPtr client = wClient(pWin); | ^~~~~~ Signed-off-by: Alan Coopersmith (cherry picked from commit 6611caf828af4833d59cd41f8c64a910f1edcac9) (cherry picked from commit 878d73e31296f59fa70c9ac56508d51f140bb9ee) Part-of: --- dix/events.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/dix/events.c b/dix/events.c index d21e1894c..8d8c4017b 100644 --- a/dix/events.c +++ b/dix/events.c @@ -4735,7 +4735,9 @@ CoreEnterLeaveEvent(DeviceIntPtr mouse, xKeymapEvent ke = { .type = KeymapNotify }; +#ifdef XACE ClientPtr client = grab ? rClient(grab) : wClient(pWin); +#endif int rc; rc = XaceHook(XACE_DEVICE_ACCESS, client, keybd, DixReadAccess); @@ -4846,7 +4848,9 @@ CoreFocusEvent(DeviceIntPtr dev, int type, int mode, int detail, WindowPtr pWin) xKeymapEvent ke = { .type = KeymapNotify }; +#ifdef XACE ClientPtr client = wClient(pWin); +#endif int rc; rc = XaceHook(XACE_DEVICE_ACCESS, client, dev, DixReadAccess);