fdo-mirrors/xserver
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/xorg/xserver.git synced 2026-05-09 20:08:21 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

glx: fix wrong pointer passed to non-swap handlers in TexImage/CopySubBuffer

Browse source 
Three GLX byte-swap dispatch functions advance the pc pointer past the
vendor private header (pc += __GLX_VENDPRIV_HDR_SIZE) for local field
swapping, then pass the ADVANCED pc to the non-swap handler. But the
non-swap handlers expect pc to point to the start of the
xGLXVendorPrivateReq — they cast pc to xGLXVendorPrivateReq* to access
req->contextTag, then do their own pc += __GLX_VENDPRIV_HDR_SIZE.

Co-Authored-by: Claude Code <noreply@anthropic.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2181>
This commit is contained in:
Peter Hutterer 2026-04-17 10:33:52 +10:00 • committed by Marge Bot
parent c98273d0bc
commit 982dcd5df4
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
glx/glxcmdsswap.c
View file

@ -639,7 +639,7 @@ __glXDispSwap_BindTexImageEXT(__GLXclientState * cl, GLbyte * pc)
__GLX_SWAP_INT(buffer);
__GLX_SWAP_INT(num_attribs);
return __glXDisp_BindTexImageEXT(cl, (GLbyte *) pc);
return __glXDisp_BindTexImageEXT(cl, (GLbyte *) req);
}
int
@ -664,7 +664,7 @@ __glXDispSwap_ReleaseTexImageEXT(__GLXclientState * cl, GLbyte * pc)
__GLX_SWAP_INT(drawId);
__GLX_SWAP_INT(buffer);
return __glXDisp_ReleaseTexImageEXT(cl, (GLbyte *) pc);
return __glXDisp_ReleaseTexImageEXT(cl, (GLbyte *) req);
}
int
@ -692,7 +692,7 @@ __glXDispSwap_CopySubBufferMESA(__GLXclientState * cl, GLbyte * pc)
__GLX_SWAP_INT(pc + 12);
__GLX_SWAP_INT(pc + 16);
return __glXDisp_CopySubBufferMESA(cl, pc);
return __glXDisp_CopySubBufferMESA(cl, (GLbyte *) req);
}