From 532987415e594aff261c9e7490fa73c720baeb22 Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Fri, 17 Apr 2026 14:43:04 +1000 Subject: [PATCH] panoramiX: fail if we can't allocate our visual arrays This code has failed for decades by triggering a segfault, let's not bother figuring out the perfect cleanup path. Co-Authored-by: Claude Code Part-of: --- Xext/panoramiX.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Xext/panoramiX.c b/Xext/panoramiX.c index 83af4e8b1..e1b55263a 100644 --- a/Xext/panoramiX.c +++ b/Xext/panoramiX.c @@ -781,16 +781,16 @@ PanoramiXMaybeAddVisual(VisualPtr pVisual) /* found a matching visual on all screens, add it to the subset list */ j = PanoramiXNumVisuals; PanoramiXNumVisuals++; - PanoramiXVisuals = reallocarray(PanoramiXVisuals, - PanoramiXNumVisuals, sizeof(VisualRec)); + PanoramiXVisuals = XNFreallocarray(PanoramiXVisuals, + PanoramiXNumVisuals, sizeof(VisualRec)); memcpy(&PanoramiXVisuals[j], pVisual, sizeof(VisualRec)); for (k = 0; k < PanoramiXNumDepths; k++) { if (PanoramiXDepths[k].depth == pVisual->nplanes) { - PanoramiXDepths[k].vids = reallocarray(PanoramiXDepths[k].vids, - PanoramiXDepths[k].numVids + 1, - sizeof(VisualID)); + PanoramiXDepths[k].vids = XNFreallocarray(PanoramiXDepths[k].vids, + PanoramiXDepths[k].numVids + 1, + sizeof(VisualID)); PanoramiXDepths[k].vids[PanoramiXDepths[k].numVids] = pVisual->vid; PanoramiXDepths[k].numVids++; break;