From 20bdec91712957c069c410ed34045f4090821ac7 Mon Sep 17 00:00:00 2001 From: Chris Wilson Date: Mon, 27 Jan 2014 09:44:48 +0000 Subject: [PATCH] render: Fix leak of filter params ==11097== 2,048 (+1,640) bytes in 32 (+26) blocks are definitely lost in loss record 1,570 of 1,719 ==11097== at 0x4C2A2DB: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==11097== by 0x225EF3: SetPicturePictFilter (filter.c:339) ==11097== by 0x22DF4F: ProcRenderSetPictureFilter (render.c:1773) ==11097== by 0x15D25D: Dispatch (dispatch.c:432) ==11097== by 0x14C7B9: main (main.c:298) [ajax: Fixed whitespace] Reviewed-by: Adam Jackson Signed-off-by: Chris Wilson (cherry picked from commit c7f84c880bbbb508016ad80390a11961b1c4214d) --- render/picture.c | 1 + 1 file changed, 1 insertion(+) diff --git a/render/picture.c b/render/picture.c index cef7032a2..fdf034a62 100644 --- a/render/picture.c +++ b/render/picture.c @@ -1392,6 +1392,7 @@ FreePicture(void *value, XID pid) if (--pPicture->refcnt == 0) { free(pPicture->transform); + free(pPicture->filter_params); if (pPicture->pSourcePict) { if (pPicture->pSourcePict->type != SourcePictTypeSolidFill)