fdo-mirrors/xorg-xorgproto
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/xorg/proto/xorgproto.git synced 2025-12-27 00:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

HideCursor/ShowCursor: Fix the interpretation of the window argument

Browse source 
In the implementation of HideCursor/ShowCursor in the xserver code,
the window passed in only identifies a screen, not a portion of the
window tree, and it's been that way since the beginning. Changing
the implementation at this point would likely break existing code,
and the main usage of this protocol (magnifiers) only needs the
global behavior, so change the protocol to document the actual
behavior.

Reviewed-by: Keith Packard <keithp@keithp.com>
Reviewed-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: Owen W. Taylor <otaylor@fishsoup.net>
This commit is contained in:
Owen W. Taylor 2015-04-08 11:30:39 -04:00 • committed by Adam Jackson
parent 67ccebd2cb
commit e4ba4e04b8
1 changed files with 6 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
fixesproto.txt
View file

@ -525,20 +525,14 @@ HideCursor
A client sends this request to indicate that it wants the A client sends this request to indicate that it wants the
cursor image to be hidden (i.e. to not be displayed) when cursor image to be hidden (i.e. to not be displayed) when
the sprite is inside the specified window, or one of its the sprite is on the same screen as the specified window.
subwindows. If the sprite is inside a window for which one The sprite will be hidden if one or more clients have called
or more active clients have requested cursor hiding then the HideCursor and not ShowCursor.
cursor image will not be displayed.
Note that even though cursor hiding causes the cursor image Note that even though cursor hiding causes the cursor image
to be invisible, CursorNotify events will still be sent to be invisible, CursorNotify events will still be sent
normally, as if the cursor image were visible. normally, as if the cursor image were visible.
If, during a grab, one or more active clients have requested
cursor hiding for grab window, or one of its ancestors, the
cursor image of the grab cursor will not be displayed during
the lifetime of that grab.
When a client with outstanding cursor hiding requests When a client with outstanding cursor hiding requests
terminates its connection these requests will be deleted. terminates its connection these requests will be deleted.
@ -552,13 +546,9 @@ ShowCursor
window: WINDOW window: WINDOW
A client sends this request to indicate that it wants the A client sends this request to indicate that it wants the
cursor image to be displayed when the sprite is inside the cursor image to be displayed when the sprite is on the same
specified window, or one of its subwindows. If the sprite screen as the specified window. The sprite will be hidden
is inside a window for which no active clients have requested if one or more clients have called HideCursor and not ShowCursor.
cursor hiding then the cursor image for that window will be
displayed. In other words, if a client calls HideCursor for
a specified window, or window subtree, this request reverses
the effects of the HideCursor request.
If the client has made no outstanding HideCursor requests If the client has made no outstanding HideCursor requests
a BadMatch error is generated. a BadMatch error is generated.