fdo-mirrors/xorg-xcbproto
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/xorg/proto/xcbproto.git synced 2026-05-09 03:38:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

xinput: rep SetDeviceMode.status: altenum to enum

Browse source 
Field "status" of the SetDeviceMode-reply
only allows values from enum GrabStatus.

Therefore it has an "enum" and not an "altenum".

Also: Add comment about valid values of field "status".

spec:
http://cgit.freedesktop.org/xorg/proto/inputproto/tree/specs/XIproto.txt#n601

note:
The following spec also mentions value "3 + first_error":
http://cgit.freedesktop.org/xorg/lib/libXi/tree/specs/encoding.xml#n891

This is probably an error in this old spec because:
* the X-Server code does not generate that value.
  In case of error-codes, it does the following:
  instead of sending the reply it returns
  rep.status containing the error-code as returnvalue
  of the function ProcXSetDeviceMode.
  This will probably cause the sending of an XError.
  code:
    http://cgit.freedesktop.org/xorg/xserver/tree/Xi/setmode.c#n86

* the new spec does not mention that value:
  http://cgit.freedesktop.org/xorg/proto/inputproto/tree/specs/XIproto.txt#n601
This commit is contained in:
Christian Linhart 2014-08-18 16:41:21 +02:00
parent 36484e600c
commit 3e6ddac96f
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/xinput.xml
View file

@ -209,7 +209,8 @@ authorization from the authors.
<pad bytes="2" />
<reply>
<pad bytes="1" />
<field type="CARD8" name="status" altenum="GrabStatus" />
<!-- values for status: 0: Success, 1: AlreadyGrabbed -->
<field type="CARD8" name="status" enum="GrabStatus" />
<pad bytes="23" />
</reply>
</request>