From 8229cf75b34c2991eaf973f05326be9bfa16ef0c Mon Sep 17 00:00:00 2001 From: Alan Coopersmith Date: Thu, 24 Nov 2011 13:10:15 -0800 Subject: [PATCH] XcursorImageLoadCursor: return failure if _XcursorGetDisplayInfo fails Error: Null pointer dereference (CWE 476) Read from null pointer 'info' at line 615 of src/cursor.c in function 'XcursorImageLoadCursor'. Function '_XcursorGetDisplayInfo' may return constant 'NULL' at line 134, called at line 597. Null pointer introduced at line 134 of src/display.c in function '_XcursorGetDisplayInfo'. [ This bug was found by the Parfait 0.3.7 bug checking tool. For more information see http://labs.oracle.com/projects/parfait/ ] Signed-off-by: Alan Coopersmith Reviewed-by: Jeremy Huddleston --- src/cursor.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cursor.c b/src/cursor.c index b36339b..92bd417 100644 --- a/src/cursor.c +++ b/src/cursor.c @@ -601,6 +601,9 @@ XcursorImageLoadCursor (Display *dpy, const XcursorImage *image) GC gc; XGCValues gcv; + if (!info) + return 0; + core.src_image = XCreateImage (dpy, NULL, 1, ZPixmap, 0, NULL, image->width, image->height, 32, 0);