José Expósito eaad761e24 Fix use of uninitialized variable in _XimExtension ... `_XimRead()` is being called with `reply` as target buffer instead of using `preply`, accessing uninitialized memory a few lines later. This error has been found by a static analysis tool. This is the report: Error: UNINIT (CWE-457): libX11-1.8.7/modules/im/ximcp/imExten.c:468: alloc_fn: Calling "malloc" which returns uninitialized memory. libX11-1.8.7/modules/im/ximcp/imExten.c:468: assign: Assigning: "preply" = "malloc((size_t)((buf_size == 0) ? 1 : buf_size))", which points to uninitialized data. libX11-1.8.7/modules/im/ximcp/imExten.c:479: uninit_use: Using uninitialized value "*((CARD8 *)preply)". # 477| return False; # 478| buf_s = (CARD16 *)((char *)preply + XIM_HEADER_SIZE); # 479|-> if (*((CARD8 *)preply) == XIM_ERROR) { # 480| _XimProcError(im, 0, (XPointer)&buf_s[3]); # 481| if(reply != preply) Signed-off-by: José Expósito <jexposit@redhat.com> Part-of: <https://gitlab.freedesktop.org/xorg/lib/libx11/-/merge_requests/250>		2024-05-07 08:54:50 +00:00
..
ximcp	Fix use of uninitialized variable in _XimExtension	2024-05-07 08:54:50 +00:00
Makefile.am	Enable loadable i18n modules, making them configurable on the configure command line.	2005-07-11 08:29:18 +00:00