From c37e278993b9e5b3d7025ef4c434373a011996ec Mon Sep 17 00:00:00 2001 From: Ander Conselvan de Oliveira Date: Mon, 31 Jan 2011 14:02:07 +0200 Subject: [PATCH] xcms/LRGB: don't double-free property_return MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit property_return was free'd before and in the case the conditional is true, the call to XcmsGetProperty failed which means that property_return wasn't set so there is no need to free it again. Double free of pointer "property_return" in call to "free" Reviewed-by: Alan Coopersmith Reviewed-by: Erkki Seppälä Signed-off-by: Ander Conselvan de Oliveira --- src/xcms/LRGB.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/xcms/LRGB.c b/src/xcms/LRGB.c index 750c4924..2dca82ee 100644 --- a/src/xcms/LRGB.c +++ b/src/xcms/LRGB.c @@ -573,7 +573,6 @@ LINEAR_RGB_InitSCCData( if (CorrectAtom == None || !_XcmsGetProperty (dpy, RootWindow(dpy, screenNumber), CorrectAtom, &format_return, &nitems, &nbytes_return, &property_return)) { - Xfree ((char *)property_return); goto FreeSCCData; }