From af2711c531b7c033c11ad215537873e73e4ebd23 Mon Sep 17 00:00:00 2001 From: Roland Mainz Date: Mon, 13 Dec 2004 02:24:22 +0000 Subject: [PATCH] //bugs.freedesktop.org/show_bug.cgi?id=1926) attachment #1482 (https://bugs.freedesktop.org/attachment.cgi?id=1482): Unregistering events in XSelectInput() when unregistering IM filter callbacks via |_XimUnRegisterIMInstantiateCallback| may be a bad idea as others may be interested in this event. Removed the call to XSelectInput() altogether as we are in root window anyway. Patch by Lubos Lunak and and Egbert Eich . --- modules/im/ximcp/imInsClbk.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/modules/im/ximcp/imInsClbk.c b/modules/im/ximcp/imInsClbk.c index 0aaba735..6dfcac4c 100644 --- a/modules/im/ximcp/imInsClbk.c +++ b/modules/im/ximcp/imInsClbk.c @@ -254,18 +254,6 @@ _XimUnRegisterIMInstantiateCallback( _XUnregisterFilter( display, RootWindow(display, 0), _XimFilterPropertyNotify, (XPointer)NULL ); -#if 0 - /* - * don't unregister the event mask - * (not even the PropertyNotify mask) - * as others may be interested. - * It shouldn't matter if we don't unregister - * as we are in the root window anyway so the - * event won't be propagated any further. - */ - XSelectInput( display, RootWindow(display, 0), - NoEventMask ); -#endif } else picb->next = icb->next;