fdo-mirrors/wlroots
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wlroots/wlroots.git synced 2025-12-20 06:50:04 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

color_management_v1: add helpers to get supported TFs/primaries

Browse source 
This avoids hardcoding lists of TFs/primaries in compositors.

I've considered adding wlr_color_manager_v1_create_with_renderer()
instead, but I'm worried that some aspects of the options struct
don't really depend on the renderer, but on the compositor. Such
things are features and render intents.

I've considered returning a const array, but this would tie our
hands if we want to make the renderer advertise the set of
TFs/primaries it supports, instead of having a single flag gating
all of them.
This commit is contained in:
Simon Ser 2025-06-18 22:31:30 +02:00 • committed by Simon Zeni
parent ba931024a5
commit 9b4d9eabb1
2 changed files with 62 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
include/wlr/types/wlr_color_management_v1.h
View file

@ -14,6 +14,7 @@
#include <wlr/render/color.h>
struct wlr_renderer;
struct wlr_surface;
struct wlr_image_description_v1_data {
@ -119,4 +120,18 @@ wlr_color_manager_v1_primaries_to_wlr(enum wp_color_manager_v1_primaries primari
enum wp_color_manager_v1_primaries
wlr_color_manager_v1_primaries_from_wlr(enum wlr_color_named_primaries primaries);
/**
* Get a list of supported transfer functions for a renderer. The caller is
* responsible for free'ing the array.
*/
enum wp_color_manager_v1_transfer_function *
wlr_color_manager_v1_transfer_function_list_from_renderer(struct wlr_renderer *renderer, size_t *len);
/**
* Get a list of supported named primaries for a renderer. The caller is
* responsible for free'ing the array.
*/
enum wp_color_manager_v1_primaries *
wlr_color_manager_v1_primaries_list_from_renderer(struct wlr_renderer *renderer, size_t *len);
#endif

47
types/wlr_color_management_v1.c
View file

@ -2,6 +2,7 @@
#include <stdlib.h>
#include <string.h>
#include <wlr/render/wlr_renderer.h>
#include <wlr/types/wlr_color_management_v1.h>
#include <wlr/types/wlr_compositor.h>
#include <wlr/types/wlr_output.h>
@ -1041,3 +1042,49 @@ wlr_color_manager_v1_primaries_from_wlr(enum wlr_color_named_primaries primaries
}
abort();
}
enum wp_color_manager_v1_transfer_function *
wlr_color_manager_v1_transfer_function_list_from_renderer(struct wlr_renderer *renderer, size_t *len) {
if (!renderer->features.input_color_transform) {
*len = 0;
return NULL;
}
const enum wp_color_manager_v1_transfer_function list[] = {
WP_COLOR_MANAGER_V1_TRANSFER_FUNCTION_SRGB,
WP_COLOR_MANAGER_V1_TRANSFER_FUNCTION_GAMMA22,
WP_COLOR_MANAGER_V1_TRANSFER_FUNCTION_ST2084_PQ,
WP_COLOR_MANAGER_V1_TRANSFER_FUNCTION_EXT_LINEAR,
};
enum wp_color_manager_v1_transfer_function *out = NULL;
if (!memdup(&out, list, sizeof(list))) {
*len = 0;
return NULL;
}
*len = sizeof(list) / sizeof(list[0]);
return out;
}
enum wp_color_manager_v1_primaries *
wlr_color_manager_v1_primaries_list_from_renderer(struct wlr_renderer *renderer, size_t *len) {
if (!renderer->features.input_color_transform) {
*len = 0;
return NULL;
}
const enum wp_color_manager_v1_primaries list[] = {
WP_COLOR_MANAGER_V1_PRIMARIES_SRGB,
WP_COLOR_MANAGER_V1_PRIMARIES_BT2020,
};
enum wp_color_manager_v1_primaries *out = NULL;
if (!memdup(&out, list, sizeof(list))) {
*len = 0;
return NULL;
}
*len = sizeof(list) / sizeof(list[0]);
return out;
}