mirror of
https://gitlab.freedesktop.org/pipewire/wireplumber.git
synced 2026-05-09 21:28:18 +02:00
2e00356c98
When WirePlumber exits, it crashes with SIGABRT. The backtrace shows: 7 g_closure_invalidate 10 g_object_unref 15 g_value_unset 16 _wplua_gvalue_userdata___gc 26 close_state (lua_close) 27 wp_plugin_deactivate 33 wp_registry_clear 34 wp_core_dispose Root cause: lua_State is referenced by both the main plugin and each WpLuaScript object. During registry cleanup, scripts call lua_close again on an already-destroyed state, causing use-after-free. Fix: - Add a prepare_shutdown vfunc in WpPlugin. Call it from wp_core_dispose *before* clearing the registry. - Lua plugin implements prepare_shutdown to close its lua_State early, allowing all __gc finalizers to run while GObjects are still alive. - Then clear the lua_State pointer from every WpLuaScript object via wp_lua_script_clear_lua_state(). - Guard WpLuaScript finalize to skip if pointer is already NULL.
28 lines
711 B
C
28 lines
711 B
C
/* WirePlumber
|
|
*
|
|
* Copyright © 2022 Collabora Ltd.
|
|
* @author George Kiagiadakis <george.kiagiadakis@collabora.com>
|
|
*
|
|
* SPDX-License-Identifier: MIT
|
|
*/
|
|
|
|
#ifndef __MODULE_LUA_SCRIPTING_SCRIPT_H__
|
|
#define __MODULE_LUA_SCRIPTING_SCRIPT_H__
|
|
|
|
#include <wp/wp.h>
|
|
#include <wplua/wplua.h>
|
|
|
|
G_BEGIN_DECLS
|
|
|
|
#define WP_TYPE_LUA_SCRIPT (wp_lua_script_get_type ())
|
|
G_DECLARE_FINAL_TYPE (WpLuaScript, wp_lua_script, WP, LUA_SCRIPT, WpPlugin)
|
|
|
|
/* Clear the internal lua_State pointer to prevent the finalizer from
|
|
* attempting to close the already-destroyed state. Called by the Lua
|
|
* scripting plugin during prepare_shutdown. */
|
|
WP_API
|
|
void wp_lua_script_clear_lua_state (WpLuaScript *self);
|
|
|
|
G_END_DECLS
|
|
|
|
#endif
|