mirror of
https://gitlab.freedesktop.org/pipewire/wireplumber.git
synced 2026-05-09 09:48:04 +02:00
2e00356c98
When WirePlumber exits, it crashes with SIGABRT. The backtrace shows: 7 g_closure_invalidate 10 g_object_unref 15 g_value_unset 16 _wplua_gvalue_userdata___gc 26 close_state (lua_close) 27 wp_plugin_deactivate 33 wp_registry_clear 34 wp_core_dispose Root cause: lua_State is referenced by both the main plugin and each WpLuaScript object. During registry cleanup, scripts call lua_close again on an already-destroyed state, causing use-after-free. Fix: - Add a prepare_shutdown vfunc in WpPlugin. Call it from wp_core_dispose *before* clearing the registry. - Lua plugin implements prepare_shutdown to close its lua_State early, allowing all __gc finalizers to run while GObjects are still alive. - Then clear the lua_State pointer from every WpLuaScript object via wp_lua_script_clear_lua_state(). - Guard WpLuaScript finalize to skip if pointer is already NULL.
58 lines
1.2 KiB
C
58 lines
1.2 KiB
C
/* WirePlumber
|
|
*
|
|
* Copyright © 2020 Collabora Ltd.
|
|
* @author George Kiagiadakis <george.kiagiadakis@collabora.com>
|
|
*
|
|
* SPDX-License-Identifier: MIT
|
|
*/
|
|
|
|
#ifndef __WIREPLUMBER_PLUGIN_H__
|
|
#define __WIREPLUMBER_PLUGIN_H__
|
|
|
|
#include "object.h"
|
|
|
|
G_BEGIN_DECLS
|
|
|
|
/*!
|
|
* \brief Flags to be used as WpObjectFeatures on WpPlugin subclasses.
|
|
* \ingroup wpplugin
|
|
*/
|
|
typedef enum { /*< flags >*/
|
|
/*! enables the plugin */
|
|
WP_PLUGIN_FEATURE_ENABLED = (1 << 0),
|
|
} WpPluginFeatures;
|
|
|
|
/*!
|
|
* \brief The WpPlugin GType
|
|
* \ingroup wpplugin
|
|
*/
|
|
#define WP_TYPE_PLUGIN (wp_plugin_get_type ())
|
|
WP_API
|
|
G_DECLARE_DERIVABLE_TYPE (WpPlugin, wp_plugin, WP, PLUGIN, WpObject)
|
|
|
|
struct _WpPluginClass
|
|
{
|
|
WpObjectClass parent_class;
|
|
|
|
void (*enable) (WpPlugin * self, WpTransition * transition);
|
|
void (*disable) (WpPlugin * self);
|
|
/* New virtual method: called during core shutdown before registry is cleared.
|
|
Uses one of the padding slots to preserve ABI. */
|
|
void (*prepare_shutdown) (WpPlugin * self);
|
|
|
|
/*< private >*/
|
|
WP_PADDING(5)
|
|
};
|
|
|
|
WP_API
|
|
WpPlugin * wp_plugin_find (WpCore * core, const gchar * plugin_name);
|
|
|
|
WP_API
|
|
const gchar * wp_plugin_get_name (WpPlugin * self);
|
|
|
|
WP_API
|
|
void wp_plugin_prepare_shutdown (WpPlugin * self);
|
|
|
|
G_END_DECLS
|
|
|
|
#endif
|