fdo-mirrors/wireplumber
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/wireplumber.git synced 2025-12-20 05:20:05 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

m-mpris: ‘Item’s are allocated with GLib

Browse source 
As are the string copies they point to, don't leak them and free them
the right way.
This commit is contained in:
Zander Brown 2025-11-05 14:12:36 +00:00
parent 17ca0ef7bb
commit b3cb42b72a
No known key found for this signature in database
GPG key ID: 25EE3C36E31E5F84
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
modules/module-mpris.c
View file

@ -98,8 +98,10 @@ static void item_free (gpointer data)
{
Item *item = data;
free(item->desktop_entry);
free(item);
g_clear_pointer (&item->desktop_entry, g_free);
g_clear_pointer (&item->flatpak_app_id, g_free);
g_clear_pointer (&item->flatpak_instance_id, g_free);
g_free (item);
}
static Players *players_new (GDBusConnection *conn)
@ -170,8 +172,8 @@ G_DEFINE_AUTOPTR_CLEANUP_FUNC (ItemUpdate, item_update_free)
static void item_get_flatpak_app_id (ItemUpdate *update, Item *item)
{
spa_autofree char *app_id = NULL;
spa_autofree char *instance_id = NULL;
g_autofree char *app_id = NULL;
g_autofree char *instance_id = NULL;
int res;
g_clear_pointer (&item->flatpak_app_id, g_free);
@ -183,7 +185,7 @@ static void item_get_flatpak_app_id (ItemUpdate *update, Item *item)
res = pw_check_flatpak (item->pid, &app_id, &instance_id, NULL);
if (res < 0) {
wp_info ("%p: failed to get Flatpak status for '%s': %d (%s)", update->players, update->bus_name,
-res, spa_strerror (res));
-res, g_strerror (res));
return;
}