fdo-mirrors/weston
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/weston.git synced 2025-12-20 04:40:07 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

compositor: Improve VRR timings

Browse source 
When we need to use VRR, we'll miss a potential frame deadline, fail to
deliver a frame, then stop the repaint loop. When a late frame comes
in, we deliver it immediately at the start of a new repaint loop.

The only time we really need to deliver a frame immediately is at
the start of the loop, otherwise we can use the same repaint window
behaviour as any other time.

This still leaves some room for improvement, as we still don't try
to avoid Vactive.

Signed-off-by: Derek Foreman <derek.foreman@collabora.com>
This commit is contained in:
Derek Foreman 2025-11-06 13:16:53 -06:00
parent 2dce06179f
commit eb61323aa1
1 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
libweston/compositor.c
View file

@ -3885,7 +3885,12 @@ weston_output_repaint_from_present(const struct weston_output *output,
if (output->frame_flags & WESTON_FINISH_FRAME_TEARING)
return late ? *now : *present_time;
if (output->vrr_mode == WESTON_VRR_MODE_GAME)
/* At the start of the repaint loop with VRR enabled - we may
* be able to paint early, so give it a try.
*/
if (output->repaint_status == REPAINT_AWAITING_COMPLETION &&
output->frame_flags & WP_PRESENTATION_FEEDBACK_INVALID &&
output->vrr_mode == WESTON_VRR_MODE_GAME)
return late ? *now : *present_time;
timespec_add_msec(&repaint_time, present_time,
@ -4222,7 +4227,8 @@ weston_output_finish_frame(struct weston_output *output,
* if we're scheduling a repaint during the vactive display
* period, but try to render immediately if we're not.
*/
if (output->vrr_mode == WESTON_VRR_MODE_GAME) {
if (output->vrr_mode == WESTON_VRR_MODE_GAME &&
presented_flags & WP_PRESENTATION_FEEDBACK_INVALID) {
/* FIXME: we should figure out if we're in Vactive to give a
* more accurate next_present time?
*/
@ -4248,8 +4254,12 @@ weston_output_finish_frame(struct weston_output *output,
* worth of time between the repaint and the presentation.
*
* Delay the deadline of the next frame, to give clients a more predictable
* timing of the repaint cycle to lock on. */
* timing of the repaint cycle to lock on. We don't bother when starting
* the repaint loop with VRR, because in that case we can potentially
* just repaint right away.
*/
while (presented_flags == WP_PRESENTATION_FEEDBACK_INVALID &&
output->vrr_mode != WESTON_VRR_MODE_GAME &&
timespec_sub_to_msec(&output->next_present, &now) < compositor->repaint_msec)
timespec_add_nsec(&output->next_present,
&output->next_present,