From d8e690656339e38a6767c486ce6cc2308d13a521 Mon Sep 17 00:00:00 2001 From: Derek Foreman Date: Tue, 5 May 2026 16:49:05 -0500 Subject: [PATCH] trace: Only add to annotation array if we're tracing Saves some effort when we're not tracing - but if we start tracing in the middle of creating an annotation it could be missing a couple of fields. Signed-off-by: Derek Foreman --- libweston/weston-trace.h | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/libweston/weston-trace.h b/libweston/weston-trace.h index 34731770b..d376da316 100644 --- a/libweston/weston-trace.h +++ b/libweston/weston-trace.h @@ -81,14 +81,16 @@ .count = 0, \ } -#define _WESTON_TRACE_ANNOTATE_ADD_GENERIC(k, v) \ - _Generic((v), \ - int: perfetto_annotate_int, \ - unsigned int: perfetto_annotate_int, \ - float: perfetto_annotate_float, \ - char *: perfetto_annotate_string, \ - const char *: perfetto_annotate_string \ - ) (&__pd_annots, k, v); +#define _WESTON_TRACE_ANNOTATE_ADD_GENERIC(k, v) \ + if (unlikely(util_perfetto_is_tracing_enabled())) { \ + _Generic((v), \ + int: perfetto_annotate_int, \ + unsigned int: perfetto_annotate_int, \ + float: perfetto_annotate_float, \ + char *: perfetto_annotate_string, \ + const char *: perfetto_annotate_string \ + ) (&__pd_annots, k, v); \ + } #define _WESTON_TRACE_ANNOTATE_ADD(k, v) \ do { \