fdo-mirrors/weston
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/weston.git synced 2026-05-05 13:28:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

compositor: Move paint node validation into a function

Browse source 
We're going to assert on a bunch of stuff, so let's put it in a function
to remove clutter.

For now it's trivial, but I'll be adding more tests shortly.

Signed-off-by: Derek Foreman <derek.foreman@collabora.com>
This commit is contained in:
Derek Foreman 2025-10-15 13:11:16 -05:00
parent 59e2a111fa
commit cb49b386f2
1 changed files with 17 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
libweston/compositor.c
View file

@ -284,6 +284,22 @@ paint_node_update_early(struct weston_paint_node *pnode)
pnode->status &= ~(PAINT_NODE_VIEW_DIRTY | PAINT_NODE_OUTPUT_DIRTY);
}
/* This is for validating a paint node after early update, assign planes,
* and late update have all taken place, so we can catch mistakes that
* could lead to broken plane composition or leaked protected content.
*
* Since these conditions are all egregious bugs, we just assert out
* of this instead of trying any kind of recovery.
*/
static void
paint_node_validate_ready(struct weston_paint_node *pnode)
{
struct weston_compositor *comp = pnode->surface->compositor;
/* If the pnode is ready to paint, it must have no dirty bits */
weston_assert_true(comp, pnode->status == PAINT_NODE_CLEAN);
}
/* Update all the paint node data that needs to be handled after
* assign_planes() completes.
*/
@ -338,10 +354,7 @@ paint_node_update_late(struct weston_paint_node *pnode)
PAINT_NODE_PLANE_DIRTY |
PAINT_NODE_BUFFER_DIRTY);
/* Nothing should be able to flip "early" bits between
* the early and late updates.
*/
assert(pnode->status == PAINT_NODE_CLEAN);
paint_node_validate_ready(pnode);
}
static struct weston_paint_node *