From c2b60e66513db342c5631fcb73c13041d3e9e075 Mon Sep 17 00:00:00 2001 From: Pekka Paalanen Date: Fri, 17 Oct 2025 12:00:32 +0300 Subject: [PATCH] ci: stop checking allow-collaboration I heard rumoours this is mostly unnecessary to check nowdays since it is the default. The real reason is that it crashes sometimes: $ ci-fairy check-merge-request --require-allow-collaboration --junit-xml=results.xml Traceback (most recent call last): File "/usr/lib/python3.12/site-packages/gitlab/exceptions.py", line 344, in wrapped_f return f(*args, **kwargs) ^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/site-packages/gitlab/mixins.py", line 125, in get server_data = self.gitlab.http_get(path, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/site-packages/gitlab/client.py", line 813, in http_get result = self.http_request( ^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/site-packages/gitlab/client.py", line 779, in http_request raise gitlab.exceptions.GitlabHttpError( gitlab.exceptions.GitlabHttpError: 403: 403 Forbidden The above exception was the direct cause of the following exception: Traceback (most recent call last): File "/usr/bin/ci-fairy", line 8, in sys.exit(ci_fairy()) ^^^^^^^^^^ File "/usr/lib/python3.12/site-packages/click/core.py", line 1161, in __call__ return self.main(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/site-packages/click/core.py", line 1082, in main rv = self.invoke(ctx) ^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/site-packages/click/core.py", line 1697, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/site-packages/click/core.py", line 1443, in invoke return ctx.invoke(self.callback, **ctx.params) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/site-packages/click/core.py", line 788, in invoke return __callback(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/site-packages/click/decorators.py", line 33, in new_func return f(get_current_context(), *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/site-packages/ci_fairy.py", line 1795, in check_merge_request mr = p.mergerequests.get(merge_request_iid) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/site-packages/gitlab/v4/objects/merge_requests.py", line 523, in get return cast(ProjectMergeRequest, super().get(id=id, lazy=lazy, **kwargs)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/site-packages/gitlab/exceptions.py", line 346, in wrapped_f raise error(e.error_message, e.response_code, e.response_body) from e gitlab.exceptions.GitlabGetError: 403: 403 Forbidden Observed in https://gitlab.freedesktop.org/elliot_chen/weston/-/jobs/86174879 Signed-off-by: Pekka Paalanen --- .gitlab-ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 2a99da3cd..2636b7469 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -116,7 +116,6 @@ check-commit: stage: "Merge request checks" script: - ci-fairy check-commits --signed-off-by --junit-xml=results.xml - - ci-fairy check-merge-request --require-allow-collaboration --junit-xml=results.xml variables: GIT_DEPTH: 100 artifacts: