fdo-mirrors/weston
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/weston.git synced 2026-05-30 17:38:17 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

renderer-gl: Also set dmabuf.rb when creating render buffer

Browse source 
gl_fbo_image_init() allocates and returns a renderbuffer through its rb
argument.
If it is not set in the dmabuf.rb field, gl_fbo_fini() will not be able to
release it and DMA buffers can start leaking.

This is usually not an issue because the DMA buffers are released when
Weston closes, but in the case of the pipewire output, the buffers are
allocated when a pipewire client connects and freed when the client
disconnects.
In that situation, dangling DMA buffers can be observed because of the
unfreed render buffer (rb).

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
This commit is contained in:
Detlev Casanova 2026-05-26 14:43:57 -04:00
parent 37860bace5
commit 4de2655f08
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
libweston/renderer-gl/gl-renderer.c
View file

@ -1064,6 +1064,7 @@ gl_renderer_create_renderbuffer_dmabuf(struct weston_output *output,
renderbuffer = xzalloc(sizeof(*renderbuffer));
renderbuffer->dmabuf.gr = gr;
renderbuffer->dmabuf.rb = rb;
renderbuffer->dmabuf.memory = dmabuf;
renderbuffer->dmabuf.image = image;
gl_renderbuffer_init(renderbuffer, RENDERBUFFER_DMABUF, fb,