fdo-mirrors/weston
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/weston.git synced 2026-05-05 02:58:02 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

window: add a note about freeing shm buffers

Browse source 
After a client has been double-buffering, and then switches to
single-buffering, it should release the 2nd buffer. That never happens
in practice here, so just add a comment and a check in case it ever
occurs in the future.

If we implemented the releasing now, it would be difficult to test.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
This commit is contained in:
Pekka Paalanen 2012-12-04 16:01:16 +02:00 • committed by Kristian Høgsberg
parent aac1c13332
commit 4dd0c412db
1 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
clients/window.c
View file

@ -833,6 +833,14 @@ shm_surface_buffer_release(void *data, struct wl_buffer *buffer)
struct shm_surface_leaf *leaf = data;
leaf->busy = 0;
/* If both leaves are now free, we should call
* shm_surface_leaf_release(shm_surface::leaf[1]).
* However, none of Weston's backends switch dynamically
* between early buffer release and requiring double-buffering,
* so if both leaves are free, we never used the second
* leaf to begin with.
*/
}
static const struct wl_buffer_listener shm_surface_buffer_listener = {
@ -851,6 +859,13 @@ shm_surface_prepare(struct toysurface *base, int dx, int dy,
surface->dx = dx;
surface->dy = dy;
/* See shm_surface_buffer_release() */
if (!surface->leaf[0].busy && !surface->leaf[1].busy &&
surface->leaf[1].cairo_surface) {
fprintf(stderr, "window.c:%s: TODO: release leaf[1]\n",
__func__);
}
/* pick a free buffer from the two */
if (!surface->leaf[0].busy)
leaf = &surface->leaf[0];