From 474dbcaf8fd8bd02dd17bc31313b6f32e001447e Mon Sep 17 00:00:00 2001 From: Pekka Paalanen Date: Mon, 19 Dec 2016 15:51:12 +0200 Subject: [PATCH] xwm: postpone geometry dirtying from pending.opaque Changing the opaque region has no immediate effect, therefore there is no need to mark the view geometry dirty. The view geometry will be invalidated automatically by the next commit from Xwayland, in weston_surface_commit_state(). The dirtying did not apply pending state. Signed-off-by: Pekka Paalanen Reviewed-by: Quentin Glidic --- xwayland/window-manager.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c index ce781591e..843a81c4b 100644 --- a/xwayland/window-manager.c +++ b/xwayland/window-manager.c @@ -1122,7 +1122,6 @@ weston_wm_window_draw_decoration(void *data) const struct weston_desktop_xwayland_interface *xwayland_interface = wm->server->compositor->xwayland_interface; uint32_t flags = 0; - struct weston_view *view; wm_log("XWM: start draw decoration, win %d\n", window->id); @@ -1167,8 +1166,6 @@ weston_wm_window_draw_decoration(void *data) window->width + 2, window->height + 2); } - wl_list_for_each(view, &window->surface->views, surface_link) - weston_view_geometry_dirty(view); pixman_region32_fini(&window->surface->pending.input); @@ -1201,7 +1198,6 @@ static void weston_wm_window_schedule_repaint(struct weston_wm_window *window) { struct weston_wm *wm = window->wm; - struct weston_view *view; int width, height; if (window->frame_id == XCB_WINDOW_NONE) { @@ -1219,8 +1215,6 @@ weston_wm_window_schedule_repaint(struct weston_wm_window *window) pixman_region32_init_rect(&window->surface->pending.opaque, 0, 0, width, height); } - wl_list_for_each(view, &window->surface->views, surface_link) - weston_view_geometry_dirty(view); } return; }