fdo-mirrors/weston
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/weston.git synced 2025-12-20 19:50:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

paint_node: Fix paint_node_damage_below

Browse source 
This list walk is broken, the intent was to walk the tail of the list
starting from the currently held node - but that is not what happens.
Instead, walk the list backwards and stop a the held node.

Also, paint_node_damage_below() is used when moving paint nodes between
planes, and in these cases we definitely don't want to limit damage to
the current plane.

Signed-off-by: Derek Foreman <derek.foreman@collabora.com>
This commit is contained in:
Derek Foreman 2023-07-20 14:52:08 -05:00
parent 550c4c3dbc
commit 43b59786e6
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
libweston/compositor.c
View file

@ -157,11 +157,12 @@ paint_node_damage_below(struct weston_paint_node *pnode)
if (!pnode->plane) if (!pnode->plane)
return; return;
wl_list_for_each(lower_node, &pnode->z_order_link, wl_list_for_each_reverse(lower_node,
z_order_link) { &pnode->output->paint_node_z_order_list,
z_order_link) {
if (lower_node->plane != pnode->plane) if (lower_node == pnode)
continue; break;
pixman_region32_union(&lower_node->damage, &lower_node->damage, pixman_region32_union(&lower_node->damage, &lower_node->damage,
&pnode->visible); &pnode->visible);