fdo-mirrors/weston
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/weston.git synced 2025-12-21 12:10:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

compositor: fix use after free in wlsc_zoom_frame

Browse source 
Add the missing return statement, so the destroyed zoom object is not
used.

Found by Valgrind.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
This commit is contained in:
Pekka Paalanen 2012-01-03 13:27:41 +02:00
parent 35ce06d4ae
commit 2da6d5f76f
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
compositor/util.c
View file

@ -189,8 +189,10 @@ wlsc_zoom_frame(struct wlsc_animation *animation,
wlsc_spring_update(&zoom->spring, msecs); wlsc_spring_update(&zoom->spring, msecs);
if (wlsc_spring_done(&zoom->spring)) if (wlsc_spring_done(&zoom->spring)) {
wlsc_zoom_destroy(zoom); wlsc_zoom_destroy(zoom);
return;
}
scale = zoom->start + scale = zoom->start +
(zoom->stop - zoom->start) * zoom->spring.current; (zoom->stop - zoom->start) * zoom->spring.current;