From 2c7dceced7da57411750706f7baa87f6f281e0ea Mon Sep 17 00:00:00 2001 From: Philipp Zabel Date: Fri, 9 Jun 2023 10:50:53 +0200 Subject: [PATCH] backend-wayland: fix memory leak in wayland_shm_buffer_attach Since the pixman_region32_t damage is initialized unconditionally, also finalize it unconditionally. Otherwise we leak rectangle memory when sb->output->frame is NULL. Reported-by: Daniel Stone Signed-off-by: Philipp Zabel --- libweston/backend-wayland/wayland.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libweston/backend-wayland/wayland.c b/libweston/backend-wayland/wayland.c index 48c21b99a..d8cf49b7f 100644 --- a/libweston/backend-wayland/wayland.c +++ b/libweston/backend-wayland/wayland.c @@ -603,8 +603,7 @@ wayland_shm_buffer_attach(struct wayland_shm_buffer *sb) rects[i].y1, rects[i].x2 - rects[i].x1, rects[i].y2 - rects[i].y1); - if (sb->output->frame) - pixman_region32_fini(&damage); + pixman_region32_fini(&damage); } static int