From 1f4d2918506bcfd63ea3c7189c7703545398e839 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Molinari?= Date: Fri, 6 Sep 2024 14:40:32 +0200 Subject: [PATCH] gl-renderer: Remove glGetError() check from gl_fbo_image_init() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove the glGetError() check from gl_fbo_image_init() after the call to glEGLImageTargetRenderbufferStorageOES(). It would probably just return a previous error queued by an unrelated GL call because the error flags aren't cleared. So instead of obfuscating the code, this commit removes that check and relies instead on the framebuffer completeness check which will better report issues. Signed-off-by: Loïc Molinari --- libweston/renderer-gl/gl-renderer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libweston/renderer-gl/gl-renderer.c b/libweston/renderer-gl/gl-renderer.c index 5bb3a6604..bd84a6a28 100644 --- a/libweston/renderer-gl/gl-renderer.c +++ b/libweston/renderer-gl/gl-renderer.c @@ -704,8 +704,6 @@ gl_fbo_image_init(struct gl_renderer *gr, glGenRenderbuffers(1, &rb); glBindRenderbuffer(GL_RENDERBUFFER, rb); gr->image_target_renderbuffer_storage(GL_RENDERBUFFER, image); - if (glGetError() == GL_INVALID_OPERATION) - goto error; glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER, rb); status = glCheckFramebufferStatus(GL_FRAMEBUFFER);