From 067e977fe1ce807788453bb9a26b6900d59671c8 Mon Sep 17 00:00:00 2001 From: Derek Foreman Date: Wed, 18 Sep 2024 09:13:19 -0500 Subject: [PATCH] desktop-shell: Don't try to move parented views on output removal These should be repositioned relative to their parents, attempting to move them independently not only doesn't make sense, but violates weston_coord sanity checks. Signed-off-by: Derek Foreman --- desktop-shell/shell.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 69e724641..2c987e192 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -4466,6 +4466,12 @@ shell_reposition_view_on_output_change(struct weston_view *view) struct shell_surface *shsurf; int visible; + /* We can't simply reposition popups and such, they must move with + * the parent. + */ + if (view->geometry.parent) + return; + if (wl_list_empty(&ec->output_list)) return;