From 4a196570a3f528e9092014f8320f4a2bb4aba680 Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Fri, 15 Nov 2013 14:17:56 +0100 Subject: [PATCH] shm: Avoid file descriptor leak upon unsuccessful mmap It would be possible to make the compositor leak file descriptors by passing descriptors of open unmmapable files to it, such as /dev/null. Signed-off-by: Lubomir Rintel --- src/wayland-shm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-shm.c b/src/wayland-shm.c index 814a4cf..590f775 100644 --- a/src/wayland-shm.c +++ b/src/wayland-shm.c @@ -241,7 +241,7 @@ shm_create_pool(struct wl_client *client, struct wl_resource *resource, wl_resource_post_error(resource, WL_SHM_ERROR_INVALID_FD, "failed mmap fd %d", fd); - goto err_free; + goto err_close; } close(fd);