fullscreen-shell: Clarify that present requests assign a surface role

Currently, the spec doesn't say explicitly that present requests assign
a surface role. Given that, it can be viewed as the protocol modifies
an already assigned surface role, e.g. xdg-toplevel, and present requests
only act as hints.

Signed-off-by: Vlad Zahorodnii <vlad.zahorodnii@kde.org>
This commit is contained in:
Vlad Zahorodnii 2021-03-23 13:33:12 +02:00 committed by Simon Ser
parent 3683a5eb66
commit af29ece33c

View file

@ -147,6 +147,10 @@
operation on the surface. This will override any kind of output operation on the surface. This will override any kind of output
scaling, so the buffer_scale property of the surface is effectively scaling, so the buffer_scale property of the surface is effectively
ignored. ignored.
This request gives the surface the role of a fullscreen shell surface.
If the surface already has another role, it raises a role protocol
error.
</description> </description>
<arg name="surface" type="object" interface="wl_surface" allow-null="true"/> <arg name="surface" type="object" interface="wl_surface" allow-null="true"/>
<arg name="method" type="uint" enum="present_method" /> <arg name="method" type="uint" enum="present_method" />
@ -192,6 +196,10 @@
then the compositor may choose a mode that matches either the buffer then the compositor may choose a mode that matches either the buffer
size or the surface size. In either case, the surface will fill the size or the surface size. In either case, the surface will fill the
output. output.
This request gives the surface the role of a fullscreen shell surface.
If the surface already has another role, it raises a role protocol
error.
</description> </description>
<arg name="surface" type="object" interface="wl_surface"/> <arg name="surface" type="object" interface="wl_surface"/>
<arg name="output" type="object" interface="wl_output"/> <arg name="output" type="object" interface="wl_output"/>
@ -204,6 +212,7 @@
These errors can be emitted in response to wl_fullscreen_shell requests. These errors can be emitted in response to wl_fullscreen_shell requests.
</description> </description>
<entry name="invalid_method" value="0" summary="present_method is not known"/> <entry name="invalid_method" value="0" summary="present_method is not known"/>
<entry name="role" value="1" summary="given wl_surface has another role"/>
</enum> </enum>
</interface> </interface>