From 9dac3d4ba6e08688a5497f6d7607f7fb9effb99a Mon Sep 17 00:00:00 2001 From: Simon Ser Date: Tue, 30 Jan 2024 11:10:09 +0100 Subject: [PATCH] xdg-shell: relax maximized size constraints In practice, no compositor is disconnecting clients with a protocol error when they don't obey the size dictated by the compositor in maximized state. It's very unlikely that any compositor would start doing so, as this would kill many existing clients. Moreover, some clients have a maximum size (e.g. dialogs), and the compositor is still allowed to mark them as maximized, in which case it's not clear how the client should react if the configured size exceeds the maximum size. Update the protocol to reflect reality. Since we still want clients to obey the size in the general case, keep the "must". Signed-off-by: Simon Ser --- stable/xdg-shell/xdg-shell.xml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/stable/xdg-shell/xdg-shell.xml b/stable/xdg-shell/xdg-shell.xml index dca033e..db61acd 100644 --- a/stable/xdg-shell/xdg-shell.xml +++ b/stable/xdg-shell/xdg-shell.xml @@ -838,8 +838,9 @@ The surface is maximized. The window geometry specified in the configure - event must be obeyed by the client, or the xdg_wm_base.invalid_surface_state - error is raised. + event must be obeyed by the client, or the compositor might not + display the toplevel faithfully (e.g. show a warning, crop or scale + the contents, display an overlay, etc). The client should draw without shadow or other decoration outside of the window geometry.