mirror of
https://gitlab.freedesktop.org/mesa/vulkan-wsi-layer.git
synced 2025-12-20 04:30:11 +01:00
Updates the present timing implementation and types to be aligned with the latest commit. Fixes an issue, where the queue used for the presentation feedback events was destroyed before getting the last events. Signed-off-by: Iason Paraskevopoulos <iason.paraskevopoulos@arm.com> Change-Id: I1dba2fd0e4ad9ec8c02d71c58c93edceaa75d07e
172 lines
6.3 KiB
C++
172 lines
6.3 KiB
C++
/*
|
|
* Copyright (c) 2025 Arm Limited.
|
|
*
|
|
* SPDX-License-Identifier: MIT
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to
|
|
* deal in the Software without restriction, including without limitation the
|
|
* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
|
|
* sell copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in all
|
|
* copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
* SOFTWARE.
|
|
*/
|
|
|
|
/**
|
|
* @file present_timing_handler.cpp
|
|
*
|
|
* @brief Contains the functionality to implement features for present timing extension.
|
|
*/
|
|
|
|
#include "present_timing_handler.hpp"
|
|
#include "surface.hpp"
|
|
|
|
namespace wsi
|
|
{
|
|
namespace wayland
|
|
{
|
|
wsi_ext_present_timing_wayland::wsi_ext_present_timing_wayland(
|
|
const util::allocator &allocator, VkDevice device, uint32_t num_images,
|
|
util::vector<std::optional<uint64_t>> &×tamp_first_pixel_out_storage)
|
|
: wsi_ext_present_timing(allocator, device, num_images)
|
|
, m_pending_presents(allocator)
|
|
, m_timestamp_first_pixel_out(allocator)
|
|
{
|
|
m_timestamp_first_pixel_out.swap(timestamp_first_pixel_out_storage);
|
|
}
|
|
|
|
util::unique_ptr<wsi_ext_present_timing_wayland> wsi_ext_present_timing_wayland::create(
|
|
VkDevice device, const util::allocator &allocator, std::optional<VkTimeDomainKHR> image_first_pixel_out_time_domain,
|
|
uint32_t num_images)
|
|
{
|
|
|
|
util::vector<util::unique_ptr<wsi::vulkan_time_domain>> domains(allocator);
|
|
if (!domains.try_push_back(allocator.make_unique<wsi::vulkan_time_domain>(
|
|
VK_PRESENT_STAGE_QUEUE_OPERATIONS_END_BIT_EXT, VK_TIME_DOMAIN_DEVICE_KHR)))
|
|
{
|
|
return nullptr;
|
|
}
|
|
|
|
if (image_first_pixel_out_time_domain.has_value())
|
|
{
|
|
std::tuple<VkTimeDomainEXT, bool> monotonic_query = { *image_first_pixel_out_time_domain, false };
|
|
|
|
const layer::device_private_data &device_data = layer::device_private_data::get(device);
|
|
auto result = wsi::check_time_domain_support(device_data.physical_device, &monotonic_query, 1);
|
|
if (result != VK_SUCCESS)
|
|
{
|
|
return nullptr;
|
|
}
|
|
|
|
if (std::get<1>(monotonic_query))
|
|
{
|
|
if (!domains.try_push_back(allocator.make_unique<wsi::vulkan_time_domain>(
|
|
VK_PRESENT_STAGE_IMAGE_FIRST_PIXEL_OUT_BIT_EXT, image_first_pixel_out_time_domain.value())))
|
|
{
|
|
return nullptr;
|
|
}
|
|
}
|
|
}
|
|
util::vector<std::optional<uint64_t>> timestamp_first_pixel_out_storage(allocator);
|
|
if (!timestamp_first_pixel_out_storage.try_resize(num_images))
|
|
{
|
|
return nullptr;
|
|
}
|
|
|
|
return wsi_ext_present_timing::create<wsi_ext_present_timing_wayland>(
|
|
allocator, domains.data(), domains.size(), device, num_images, std::move(timestamp_first_pixel_out_storage));
|
|
}
|
|
|
|
VkResult wsi_ext_present_timing_wayland::get_swapchain_timing_properties(
|
|
uint64_t &timing_properties_counter, VkSwapchainTimingPropertiesEXT &timing_properties)
|
|
{
|
|
timing_properties_counter = 0;
|
|
timing_properties.refreshDuration = 0;
|
|
timing_properties.refreshInterval = 0;
|
|
|
|
return VK_SUCCESS;
|
|
}
|
|
|
|
presentation_feedback *wsi_ext_present_timing_wayland::insert_into_pending_present_feedback_list(
|
|
uint32_t image_index, struct wp_presentation_feedback *feedback_obj)
|
|
{
|
|
scoped_mutex lock(m_pending_presents_lock);
|
|
presentation_feedback fb(feedback_obj, this, image_index);
|
|
size_t position = m_pending_presents.size();
|
|
if (!m_pending_presents.try_push_back(std::move(fb)))
|
|
{
|
|
return nullptr;
|
|
}
|
|
return &m_pending_presents[position];
|
|
}
|
|
|
|
void wsi_ext_present_timing_wayland::remove_from_pending_present_feedback_list(uint32_t image_index)
|
|
{
|
|
scoped_mutex lock(m_pending_presents_lock);
|
|
auto it = std::find_if(m_pending_presents.begin(), m_pending_presents.end(),
|
|
[image_index](const presentation_feedback &p) { return p.get_image_index() == image_index; });
|
|
|
|
if (it != m_pending_presents.end())
|
|
{
|
|
m_pending_presents.erase(it);
|
|
}
|
|
}
|
|
|
|
void wsi_ext_present_timing_wayland::pixelout_callback(uint32_t image_index, uint64_t time)
|
|
{
|
|
/* m_timestamp_first_pixel_out for a particular index is updated by thread safe Wayland event
|
|
* and is read only after the event had processed. This is because we get the read request
|
|
* either during the get_free_buffer() or by calling the dispatch_queue(). Additionally, the
|
|
* variable being std::optional, there is no time-race happening due to hardware reording.
|
|
* This is because the variable is read after checking for whether it has value.
|
|
* This way each index of the variable is thread safe.
|
|
*/
|
|
m_timestamp_first_pixel_out[image_index] = time;
|
|
}
|
|
|
|
VkResult wsi_ext_present_timing_wayland::get_pixel_out_timing_to_queue(
|
|
uint32_t image_index, std::optional<std::reference_wrapper<swapchain_presentation_timing>> stage_timing_optional)
|
|
{
|
|
/* Try to get the event until there are no more events in
|
|
* the queue or till we get the presentation callback. */
|
|
while (!m_timestamp_first_pixel_out[image_index].has_value())
|
|
{
|
|
int res = dispatch_queue(m_display, m_queue, 0);
|
|
if (res < 0)
|
|
{
|
|
return VK_ERROR_SURFACE_LOST_KHR;
|
|
}
|
|
else if (res == 0)
|
|
{
|
|
break;
|
|
}
|
|
}
|
|
if (m_timestamp_first_pixel_out[image_index].has_value())
|
|
{
|
|
stage_timing_optional->get().set_time(m_timestamp_first_pixel_out[image_index].value());
|
|
m_timestamp_first_pixel_out[image_index].reset();
|
|
}
|
|
return VK_SUCCESS;
|
|
}
|
|
|
|
void wsi_ext_present_timing_wayland::init(wl_display *display, struct wl_event_queue *queue)
|
|
{
|
|
/* These objects shouldn't be set twice */
|
|
assert(m_display == nullptr);
|
|
assert(m_queue == nullptr);
|
|
m_display = display;
|
|
m_queue = queue;
|
|
}
|
|
|
|
} // namespace wayland
|
|
} // namespace wsi
|