From c175b19ccb12fcb5d0bd8d63600b126c1e46c3c7 Mon Sep 17 00:00:00 2001
From: Maged Elnaggar <maged.elnaggar@arm.com>
Date: Mon, 15 Sep 2025 11:31:41 +0000
Subject: [PATCH] Silence clang-tidy warnings

Silence warnings till we investigate
unrelated warnings to the project

Signed-off-by: Maged Elnaggar <maged.elnaggar@arm.com>
Change-Id: Id557ffcd96dcccfb8f8a2c58d84a229e53b2ab03
---
 .gitlab-ci.yml | 108 ++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 107 insertions(+), 1 deletion(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 69a6d8f..1c50e68 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -48,6 +48,9 @@ stages: [lint, build]
     if [ "$i" -eq "$max_tries" ]; then
       echo "DNF failed after $max_tries attempts"; exit 1;
     fi
+  - clang-tidy --version || true
+  - gcc --version || true
+  - cmake --version || true
   - mkdir -p /build
   - pushd /build
   - git clone --depth=1 https://github.com/KhronosGroup/Vulkan-Loader.git
@@ -90,7 +93,105 @@ clang_tidy:
     - test -f build/compile_commands.json || { echo "compile_commands.json missing"; exit 2; }
     # Run clang-tidy across all TUs in the DB; restrict diagnostics to this repo
     - set +e
-    - run-clang-tidy -p build -j "$(nproc)" -quiet -header-filter="$(pwd)/.*" | tee clang-tidy.log
+    - set -o pipefail
+    - |
+      run-clang-tidy -p build -j "$(nproc)" -quiet -header-filter="$(pwd)/.*" \
+      -checks='*,
+      -bugprone-easily-swappable-parameters,
+      -bugprone-exception-escape,
+      -bugprone-implicit-widening-of-multiplication-result,
+      -bugprone-sizeof-expression,
+      -bugprone-suspicious-stringview-data-usage,
+      -bugprone-use-after-move,
+
+      -cert-dcl50-cpp,
+      -cert-err33-c,
+      -cert-err58-cpp,
+
+      -clang-analyzer-optin.performance.Padding,
+
+      -concurrency-mt-unsafe,
+
+      -cppcoreguidelines-avoid-c-arrays,
+      -cppcoreguidelines-avoid-const-or-ref-data-members,
+      -cppcoreguidelines-avoid-do-while,
+      -cppcoreguidelines-avoid-magic-numbers,
+      -cppcoreguidelines-avoid-non-const-global-variables,
+      -cppcoreguidelines-explicit-virtual-functions,
+      -cppcoreguidelines-init-variables,
+      -cppcoreguidelines-macro-usage,
+      -cppcoreguidelines-non-private-member-variables-in-classes,
+      -cppcoreguidelines-no-malloc,
+      -cppcoreguidelines-noexcept-move-operations,
+      -cppcoreguidelines-owning-memory,
+      -cppcoreguidelines-prefer-member-initializer,
+      -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
+      -cppcoreguidelines-pro-bounds-constant-array-index,
+      -cppcoreguidelines-pro-bounds-pointer-arithmetic,
+      -cppcoreguidelines-pro-type-const-cast,
+      -cppcoreguidelines-pro-type-cstyle-cast,
+      -cppcoreguidelines-pro-type-member-init,
+      -cppcoreguidelines-pro-type-reinterpret-cast,
+      -cppcoreguidelines-pro-type-union-access,
+      -cppcoreguidelines-pro-type-vararg,
+      -cppcoreguidelines-special-member-functions,
+      -cppcoreguidelines-use-default-member-init,
+
+      -hicpp-avoid-c-arrays,
+      -hicpp-braces-around-statements,
+      -hicpp-explicit-conversions,
+      -hicpp-invalid-access-moved,
+      -hicpp-member-init,
+      -hicpp-named-parameter,
+      -hicpp-no-array-decay,
+      -hicpp-no-malloc,
+      -hicpp-noexcept-move,
+      -hicpp-signed-bitwise,
+      -hicpp-special-member-functions,
+      -hicpp-uppercase-literal-suffix,
+      -hicpp-use-equals-default,
+      -hicpp-use-equals-delete,
+      -hicpp-use-nullptr,
+      -hicpp-use-override,
+      -hicpp-vararg,
+
+      -misc-const-correctness,
+      -misc-include-cleaner,
+      -misc-misplaced-const,
+      -misc-non-private-member-variables-in-classes,
+      -misc-use-anonymous-namespace,
+      -misc-use-internal-linkage,
+
+      -performance-enum-size,
+      -performance-noexcept-move-constructor,
+
+      -readability-avoid-const-params-in-decls,
+      -readability-braces-around-statements,
+      -readability-container-data-pointer,
+      -readability-container-size-empty,
+      -readability-const-return-type,
+      -readability-convert-member-functions-to-static,
+      -readability-else-after-return,
+      -readability-function-cognitive-complexity,
+      -readability-identifier-length,
+      -readability-implicit-bool-conversion,
+      -readability-inconsistent-declaration-parameter-name,
+      -readability-magic-numbers,
+      -readability-make-member-function-const,
+      -readability-named-parameter,
+      -readability-qualified-auto,
+      -readability-redundant-member-init,
+      -readability-simplify-boolean-expr,
+      -readability-uppercase-literal-suffix,
+
+      -altera-*,
+      -boost-*,
+      -fuchsia-*,
+      -google-*,
+      -llvm-*,
+      -llvmlibc-*,
+      -modernize-*' \
+      | tee clang-tidy.log
     - set -e
     # Fail if any warnings/errors were emitted for repo files
     - |
@@ -107,6 +208,11 @@ clang_tidy:
 build_vulkan_wsi_layer:
   stage: build
   image: "registry.fedoraproject.org/fedora"
+  # Build on MRs, default branch, and tags (so tag pipelines perform a build)
+  rules:
+    - if: $CI_PIPELINE_SOURCE == 'merge_request_event'
+    - if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH
+    - if: $CI_COMMIT_TAG
   before_script:
     - *vulkan_loader_setup
   script: