fdo-mirrors/vulkan-wsi-layer
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/vulkan-wsi-layer.git synced 2026-05-05 13:28:00 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix issues flagged by static analysis

Browse source 
Add error handling to snprintf.

Signed-off-by: Dennis Tsiang <dennis.tsiang@arm.com>
Change-Id: Id0c0478254c57cb62af6f9cadde16f73b071f466
This commit is contained in:
Dennis Tsiang 2024-01-04 09:48:45 +00:00
parent 760d2f220d
commit 7fda25462e
1 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
util/extension_list.cpp
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2019, 2021-2022 Arm Limited.
* Copyright (c) 2019, 2021-2024 Arm Limited.
*
* SPDX-License-Identifier: MIT
*
@ -45,16 +45,26 @@ VkResult extension_list::add(const char *const *extensions, size_t count)
{
return VK_ERROR_OUT_OF_HOST_MEMORY;
}
for (size_t i = 0; i < count; i++)
{
auto &dst = m_ext_props[initial_size + i];
const size_t len = strlen(extensions[i]);
if (len >= sizeof(dst.extensionName))
bool success = false;
if (len < sizeof(dst.extensionName))
{
int chars_printed = snprintf(dst.extensionName, len + 1, "%s", extensions[i]);
if (chars_printed == len)
{
success = true;
}
}
if (!success)
{
abort();
}
snprintf(dst.extensionName, len + 1, "%s", extensions[i]);
}
return VK_SUCCESS;
}