Commit graph

391 commits

Author SHA1 Message Date
Bastien Nocera
68584d33f4 linux: Split the integration test into individual tests
unittest_inspector.py lists the tests in the integration-test.py script,
which are then added as individual tests.
2021-09-07 11:42:24 +02:00
Bastien Nocera
20cb2e9610 linux: Rename integration test script
Add the python suffix.
2021-09-07 11:42:17 +02:00
Bastien Nocera
9b93b6c402 build: Remove autotools 2021-09-06 14:06:40 +02:00
Benjamin Berg
f2e702d4dc build: Support building upower with meson 2021-09-02 17:47:30 +02:00
Benjamin Berg
46ed299451 tests: Return 77 when skipping tests
77 is the special value meaning that the test was skipped. Both meson
make check will display the information correctly.

Note that the test is currently executed directly in check-local. So add
a workaround to ignore the 77 error code and exit 0 instead in that
case.
2021-09-02 17:40:56 +02:00
Dylan Van Assche
3acbedca26 tests: Test inhibitor lock for critical action
Inhibitor lock should be taken between the critical
action notification and the execution of the critical action.

Requires python-dbusmock > 0.23.1, test is skipped on lower versions.

python-dbusmock in the CI is installed from git and bumped version
to 0.23.2 until a new release is available.
2021-08-17 14:31:25 +02:00
Dylan Van Assche
40e5d237cf up-backend: add inhibitor lock interface
Phones are suspended most of the time so they are not awake for > 20s
to allow UPower to take action when battery is critical.
Add an interface to take and release inhibitor locks which
prevent the device from suspending to allow UPower to execute
the critical power action.
2021-08-17 14:12:19 +02:00
Bastien Nocera
26c90728c3 linux: Add test for touchpads being tagged as mice
udev adds both tags to touchpads, so replicate that behaviour.
2021-08-10 10:47:37 +00:00
Bastien Nocera
781e856974 linux: Fix touchpad not being the right type
Touchpads are also tagged as mice, so make sure that we check for
the touchpad property before checking for mouse one.
2021-08-10 10:47:37 +00:00
Bastien Nocera
3b91711e82 linux: Don't throw away large but possible energy rates
USB PD 3.1 allows up to 240W (48V, 5A) and some proprietary supplies
already delivered more than 100W over USB-C (USB PD 3.0 limit).

Closes: #147

Reported by StefanBruens
2021-08-10 12:32:24 +02:00
Pablo Correa Gómez
d8482bc767 tests: Add test for non-default low level 2021-06-30 10:56:25 +02:00
Philipp Zabel
b64902eed2 tests: Add a test case for batteries with zero power draw
Make sure that the issue reported in #7 and #44 is fixed.
The mocked battery has a zero power_now attribute and a non-zero legacy
current_now attribute on purpose, to detect if upowerd tries to read
current_now if the power_now value is small.
2021-06-17 18:15:01 +02:00
Philipp Zabel
2949136b15 linux: Fix < 0.01 W energy-rate readings from power_now sysfs property
Currently, if a power supplies' power_now sysfs file reports discharge
rates < 0.01 W, the code will try to calculate the discharge rate from
the legacy sysfs files. On new kernels where those don't exist, this
produces wrong results.

For example, on a dual-battery Thinkpad T450s, while the external
battery is discharging, the internal battery reports power_now = 0,
but the corresponding upower energy-rate field incorrectly reads
about 2.3 W.

This patch fixes the issue by falling back to the legacy code only if
the legacy current_now sysfs file exists.

Closes: #7, #44
2021-06-17 18:14:53 +02:00
Bastien Nocera
96ea5b3521 linux: Make unknown Bluetooth devices appear as generic
Make Bluetooth devices for which we can't guess the "kind" or form
factor be "generic Bluetooth" devices, rather than "unknown" devices.

That should make it clearer in UIs that the devices are Bluetooth rather
than connected to the computer somehow.

Closes: #137
2021-06-17 13:47:33 +02:00
Bastien Nocera
d2053eff93 linux: Remove user-space support for Logitech Unifying devices
All those devices have been supported in the Linux kernel for a number
of years already, so the user-space support has just not been exercised.
2021-06-17 12:49:59 +02:00
Bastien Nocera
b09846dbed linux: Remove sysfs-utils helpers
They've been replaced by gudev functions.
2021-06-17 12:02:42 +02:00
Bastien Nocera
0e3c511d2a linux: Use new uncached sysfs attr gudev API 2021-06-17 12:01:38 +02:00
Bastien Nocera
fe9332cbe4 linux: Use existing gudev functions in Watts-Up driver 2021-06-17 12:00:18 +02:00
Bastien Nocera
2ab63bd81b linux: Fix typo in test comment 2021-06-17 12:00:08 +02:00
Bastien Nocera
dfce006c21 linux: Simplify is_macbook() function 2021-06-17 12:00:06 +02:00
Bastien Nocera
15fb868cf1 linux: Ignore "capacity" sysfs on Macs
capacity is supposed to be the running battery percentage, not a
representation of its current state of the factory capacity (which
isn't something that's ever shown in Linux or macOS).

Use the new "ignore-system-percentage" property to work-around that
problem.

Closes: #141, #103
2021-06-17 11:13:58 +02:00
Bastien Nocera
4496ebeb0a linux: Move functions
No functional changes.
2021-06-17 10:52:04 +02:00
Bastien Nocera
fa23d1be0c linux: Add property to ignore the "capacity" sysfs value
On some hardware, the "capacity" sysfs contains the capacity of the
battery when full compared to when it was new, instead of the percentage
of battery available.

Make it possible to ignore the "capacity" with this new property.
2021-06-17 10:40:19 +02:00
Marijn Suijten
8e5b1d6b46 tests: Add test cases for Bluetooth device classes 2021-02-02 18:23:19 +01:00
Marijn Suijten
15329e840c tests: Move BlueZ battery setup into helper function 2021-02-02 18:22:42 +01:00
Marijn Suijten
62d7c08289 tests: Convert unpacked tuple constants to range() 2021-02-02 18:22:42 +01:00
Marijn Suijten
98cf71fbcc linux: Parse kind from Class if Appearance is not available
Not all headsets have a GAP profile revealing their appearance, but they
do have a class.
2021-02-02 18:22:41 +01:00
Bastien Nocera
64582256a8 build: Remove libusb dependency in Linux
As the last user, the CSR support code, was removed.
2021-01-19 13:31:25 +01:00
Bastien Nocera
4227d0c439 linux: Remove support for CSR devices
Those devices date back from the mid-2000s. If they still work, and
somebody is still interested in having them export their battery status,
we would recommend moving this information to the appropriate kernel
drivers.
2021-01-19 13:29:23 +01:00
Bastien Nocera
dde6f714ea linux: Set update-time for BlueZ devices
When the battery percentage for a BlueZ device changes, change the
update-time so that the charge history is somewhat useful.
2021-01-18 22:11:32 +01:00
Bastien Nocera
67eefa17dd lib: Add "Touchpad" device type 2020-12-16 13:09:04 +01:00
Bastien Nocera
c6d2618e95 linux: Fix gudev includes for UpInput 2020-11-05 16:40:36 +01:00
Bastien Nocera
d697b39408 linux: Add support for running under umockdev
The sysfs path needs to be adjusted when running under umockdev.
2020-11-05 16:22:28 +01:00
Bastien Nocera
522fb6fff2 linux: Don't throw debug errors unless needed
It's really confusing seeing "not a switch [...]" when we actually
managed to find a switch, so throw 2 errors in the debug when both
checks fail, rather than as things are being tested.
2020-11-05 16:13:43 +01:00
Bastien Nocera
47481f3a57 linux: Fix warning when compiling with meson
src/up-input.c:294:3: warning: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Wimplicit-function-declaration]
  294 |   close (input->eventfp);
      |   ^~~~~
      |   pclose
2020-10-23 14:34:34 +02:00
Bastien Nocera
4a3cc71aa6 linux: Remove unneeded header from up-input.h
Missed in an earlier commit.

Fixes: 7ddb75166d ("linux: Remove UpDaemon dependency from UpInput")
2020-10-23 14:33:27 +02:00
Bastien Nocera
809d69e66e linux: Remove unused headers in up-input.c 2020-10-22 16:53:45 +02:00
Bastien Nocera
7ddb75166d linux: Remove UpDaemon dependency from UpInput
Emit signals from UpInput for UpBackend to consume, rather than having
UpInput poke the daemon directly.
2020-10-22 16:52:37 +02:00
Bastien Nocera
50c48e0bcb linux: Make watched switch a property of UpInput
And add up_input_new_for_switch() to watch other switches.
2020-10-22 16:51:28 +02:00
Bastien Nocera
e87cc7b47c linux: Remove duplicate header in up-input.c 2020-10-22 16:50:04 +02:00
Bastien Nocera
c987ca4ed2 linux: Simplify UpInput object code
Use G_DECLARE_FINAL_TYPE() to clean up header and remove the use of a
private struct, as the whole object struct is now private.
2020-10-22 16:50:02 +02:00
Bastien Nocera
ba153833fa linux: Clarify UpInput device handling
Despite what the comments say, the device is indeed a valid input
device, it's just not one we want to add to the power devices,
as done in up-daemon.c's up_daemon_device_added_cb().
2020-10-22 14:09:08 +02:00
Bastien Nocera
6ff9ee702e linux: Fix umockdev link in test 2020-06-18 16:13:18 +02:00
Bastien Nocera
97185bae75 linux: Add support for iPhone XR, XS models
Modifying the udev serial to be acceptable as an hyphened UDID, as the
usbmux stack expects.

Closes: #114
2020-06-17 11:01:30 +02:00
Bastien Nocera
d2917c0c71 tests: Add a keyboard/mouse combo device test 2020-05-05 16:11:45 +02:00
Bastien Nocera
e0b8354e9c linux: Identify keyboard/pointing device combos as keyboards
Rather than using the type of the first sibling device we find, which is
usually the pointing device portion, make sure that keyboard/pointing
device combo devices are identified as keyboards.
2020-05-05 16:11:42 +02:00
Bastien Nocera
85cd95ae53 linux: Detect Bluetooth pens
Numbers from:
https://www.bluetooth.com/specifications/assigned-numbers/baseband/
2019-10-24 12:52:53 +02:00
Bastien Nocera
72b85b8c13 lib: Add "Pen" device type
So we can track the battery information for powered tablet pens, rather
than labelling them as tablets.
2019-10-24 12:50:26 +02:00
Bastien Nocera
a1a437d7b1 linux: Add test for Appearance property being missing
Similar test to the test_bluetooth_le_mouse() one, but without an
appearance property.
2019-10-23 13:32:08 +02:00
Bastien Nocera
27541a6130 linux: Remove unused code in test suite
There's no need to create a udev device, the metadata comes from bluez.
2019-10-23 13:32:08 +02:00