diff --git a/src/dkp-device.c b/src/dkp-device.c index 3123040..76b0f99 100644 --- a/src/dkp-device.c +++ b/src/dkp-device.c @@ -224,6 +224,7 @@ dkp_device_removed (DkpDevice *device) { //DkpDeviceClass *klass = DKP_DEVICE_GET_CLASS (device); //klass->removed (device); + g_return_if_fail (DKP_IS_DEVICE (device)); dkp_warning ("do something here?"); } @@ -237,6 +238,8 @@ dkp_device_get_on_battery (DkpDevice *device, gboolean *on_battery) { DkpDeviceClass *klass = DKP_DEVICE_GET_CLASS (device); + g_return_val_if_fail (DKP_IS_DEVICE (device), FALSE); + /* no support */ if (klass->get_stats == NULL) return FALSE; @@ -254,6 +257,8 @@ dkp_device_get_low_battery (DkpDevice *device, gboolean *low_battery) { DkpDeviceClass *klass = DKP_DEVICE_GET_CLASS (device); + g_return_val_if_fail (DKP_IS_DEVICE (device), FALSE); + /* no support */ if (klass->get_low_battery == NULL) return FALSE; @@ -271,6 +276,8 @@ dkp_device_coldplug (DkpDevice *device, DkpDaemon *daemon, DevkitDevice *d) const gchar *native_path; DkpDeviceClass *klass = DKP_DEVICE_GET_CLASS (device); + g_return_val_if_fail (DKP_IS_DEVICE (device), FALSE); + /* save */ device->priv->d = g_object_ref (d); device->priv->daemon = g_object_ref (daemon); @@ -305,6 +312,8 @@ dkp_device_get_statistics (DkpDevice *device, const gchar *type, guint timespan, GValue *value; guint i; + g_return_val_if_fail (DKP_IS_DEVICE (device), FALSE); + /* doesn't even try to support this */ if (klass->get_stats == NULL) { error = g_error_new (DKP_DAEMON_ERROR, DKP_DAEMON_ERROR_GENERAL, "device does not support getting stats"); @@ -381,6 +390,9 @@ gboolean dkp_device_refresh (DkpDevice *device, DBusGMethodInvocation *context) { gboolean ret; + + g_return_val_if_fail (DKP_IS_DEVICE (device), FALSE); + ret = dkp_device_refresh_internal (device); dbus_g_method_return (context); return ret; @@ -395,6 +407,8 @@ dkp_device_changed (DkpDevice *device, DevkitDevice *d, gboolean synthesized) { gboolean keep_device; + g_return_val_if_fail (DKP_IS_DEVICE (device), FALSE); + g_object_unref (device->priv->d); device->priv->d = g_object_ref (d); @@ -417,18 +431,21 @@ out: const gchar * dkp_device_get_object_path (DkpDevice *device) { + g_return_val_if_fail (DKP_IS_DEVICE (device), NULL); return device->priv->object_path; } DkpObject * dkp_device_get_obj (DkpDevice *device) { + g_return_val_if_fail (DKP_IS_DEVICE (device), NULL); return device->priv->obj; } DevkitDevice * dkp_device_get_d (DkpDevice *device) { + g_return_val_if_fail (DKP_IS_DEVICE (device), NULL); return device->priv->d; } @@ -438,6 +455,8 @@ dkp_device_get_d (DkpDevice *device) void dkp_device_emit_changed (DkpDevice *device) { + g_return_if_fail (DKP_IS_DEVICE (device)); + dkp_debug ("emitting changed on %s", device->priv->obj->native_path); g_signal_emit_by_name (device->priv->daemon, "device-changed", device->priv->object_path, NULL); @@ -552,7 +571,6 @@ dkp_device_class_init (DkpDeviceClass *klass) object_class->get_property = dkp_device_get_property; object_class->finalize = dkp_device_finalize; - g_type_class_add_private (klass, sizeof (DkpDevicePrivate)); signals[CHANGED_SIGNAL] =