pulseaudio/src
Erich Boleyn b03a650160 reserve-device: allow building without D-Bus
Lennart Poettering <lennart@poettering.net> wrote:

> On Wed, 15.04.09 16:26, Erich Boleyn (erich@uruk.org) wrote:
>
> > Just noticed the new 0.9.15 release, got it building on Gentoo, and then
> > found that the non-dbus build's ALSA modules appear to be broken:
...
> > Is this something that can stubbed out (relatively) safely?
>
> Hmm, yes. As it seems I broke the build for non-dbus builds. Should be
> easy to fix. Best way is probably to make the reserver wrapper mostly
> a noop if D-Bus is not available.
>
> Please understand that I don't really focus on making every weird
> combination of build deps work. So I won't fix this for you. But I am
> happy to merge good patches!

No problem, I was mainly looking for a hint that to your knowledge there
should be no wierd side-effects from stubbing out the reserve and dbus
functions inside reserve_wrapper.  Thanks for said hint.  ;-)

Attached is a patch to include "reserve_wrapper.[ch]" in the non-dbus
builds, and do said stubbing when HAVE_DBUS is not defined.  It has
passed moderate testing:  built both versions, both pass
"pulseaudio --dump-modules" with no weird messages, and the
"--disable-dbus" build works and produces audio as expected in some
simple tests including RTP.
2009-04-19 02:06:33 +02:00
..
daemon explcitly ignore return values of some functions marked with gcc's warn_unused_result attribute 2009-04-14 01:22:42 +02:00
modules reserve-device: allow building without D-Bus 2009-04-19 02:06:33 +02:00
pulse pulse/context: when NOFAIL, don't try_next_connection() if c->client 2009-04-17 22:41:26 +02:00
pulsecore object: keep refcount at 1 while destructing objects 2009-04-18 23:24:36 +02:00
tests add a few missing initializations 2009-04-14 01:23:07 +02:00
utils pacat: add missing newline 2009-04-14 01:03:34 +02:00
.gitignore ignore tags file 2009-02-24 11:35:47 +01:00
depmod.py remove remaining $ 2008-06-18 22:38:32 +02:00
Makefile.am reserve-device: allow building without D-Bus 2009-04-19 02:06:33 +02:00
map-file add buffer_attr callback stuff to exported symbol list 2009-04-01 00:33:40 +02:00