fdo-mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2026-01-26 12:00:24 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
pulseaudio/src/modules/alsa
History
Takashi Sakamoto 5287f09f06 alsa: remove double calls of snd_pcm_prepare() 
In alsa-lib, snd_pcm_hw_params() internally calls snd_pcm_prepare(), thus
user space applications have no need to call snd_pcm_prepare() after calls
of snd_pcm_hw_params(). An explicit calls of snd_pcm_prepare() is expected
in a case to recover PCM substreams.

Current implementation of PulseAudio modules for ALSA playbacking/capturing
results in double calls of snd_pcm_prepare(). The second call for hw plugin
of alsa-lib executes ioctl(2) with SNDRV_PCM_IOCTL_PREPARE command in state
of SNDRV_PCM_STATE_PREPARED for the PCM substream. This has no effects to
the PCM substream as long as corresponding drivers are implemented
correctly.

This commit removes the second call for the reason.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
2017-01-19 03:00:45 +02:00
..
mixer alsa-mixer: Support for Creative SoundBlaster Omni Surround 5.1 USB sound card with latest firmware 2016-04-19 16:44:41 +03:00
alsa-mixer.c alsa: Use pa_device_port->impl_free() for freeing port data 2016-06-22 21:04:47 +05:30
alsa-mixer.h alsa-mixer: Fill in input and output names 2015-11-22 04:59:21 +02:00
alsa-sink.c don't assume that pa_asyncq_new() always succeeds 2016-12-20 01:19:06 +02:00
alsa-sink.h update FSF addresses to FSF web page 2015-01-14 22:20:40 +02:00
alsa-source.c don't assume that pa_asyncq_new() always succeeds 2016-12-20 01:19:06 +02:00
alsa-source.h update FSF addresses to FSF web page 2015-01-14 22:20:40 +02:00
alsa-ucm.c alsa: Use pa_device_port->impl_free() for freeing port data 2016-06-22 21:04:47 +05:30
alsa-ucm.h alsa: Use pa_device_port->impl_free() for freeing port data 2016-06-22 21:04:47 +05:30
alsa-util.c alsa: remove double calls of snd_pcm_prepare() 2017-01-19 03:00:45 +02:00
alsa-util.h update FSF addresses to FSF web page 2015-01-14 22:20:40 +02:00
module-alsa-card.c alsa: Check pa_modargs_get_value_boolean() retval for use_ucm 2016-08-15 23:53:32 +02:00
module-alsa-sink.c update FSF addresses to FSF web page 2015-01-14 22:20:40 +02:00
module-alsa-source.c update FSF addresses to FSF web page 2015-01-14 22:20:40 +02:00