fdo-mirrors/power-profiles-daemon
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/upower/power-profiles-daemon.git synced 2026-05-08 19:28:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

intel-pstate: Don't show degraded perf with CPUs with no turbo

Browse source 
Don't show a degraded performance, caused by "no_turbo" being set,
when the CPU doesn't support TurboBoost at all.

Closes: #75
This commit is contained in:
Bastien Nocera 2022-01-31 10:48:01 +01:00
parent c63503be97
commit ca79f80635
2 changed files with 28 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
src/ppd-driver-intel-pstate.c
View file

@ -14,6 +14,7 @@
#define CPUFREQ_POLICY_DIR "/sys/devices/system/cpu/cpufreq/"
#define NO_TURBO_PATH "/sys/devices/system/cpu/intel_pstate/no_turbo"
#define TURBO_PCT_PATH "/sys/devices/system/cpu/intel_pstate/turbo_pct"
struct _PpdDriverIntelPstate
{
@ -106,6 +107,23 @@ open_policy_dir (void)
return g_dir_open (dir, 0, NULL);
}
static gboolean
has_turbo (void)
{
g_autofree char *turbo_pct_path = NULL;
g_autofree char *contents = NULL;
gboolean has_turbo = TRUE;
turbo_pct_path = ppd_utils_get_sysfs_path (TURBO_PCT_PATH);
if (g_file_get_contents (turbo_pct_path, &contents, NULL, NULL)) {
contents = g_strchomp (contents);
if (g_strcmp0 (contents, "0") == 0)
has_turbo = FALSE;
}
return has_turbo;
}
static gboolean
ppd_driver_intel_pstate_probe (PpdDriver *driver)
{
@ -137,14 +155,16 @@ ppd_driver_intel_pstate_probe (PpdDriver *driver)
if (ret != PPD_PROBE_RESULT_SUCCESS)
goto out;
/* Monitor the first "no_turbo" */
pstate->no_turbo_path = ppd_utils_get_sysfs_path (NO_TURBO_PATH);
pstate->no_turbo_mon = monitor_no_turbo_prop (pstate->no_turbo_path);
if (pstate->no_turbo_mon) {
g_signal_connect (G_OBJECT (pstate->no_turbo_mon), "changed",
G_CALLBACK (no_turbo_changed), pstate);
if (has_turbo ()) {
/* Monitor the first "no_turbo" */
pstate->no_turbo_path = ppd_utils_get_sysfs_path (NO_TURBO_PATH);
pstate->no_turbo_mon = monitor_no_turbo_prop (pstate->no_turbo_path);
if (pstate->no_turbo_mon) {
g_signal_connect (G_OBJECT (pstate->no_turbo_mon), "changed",
G_CALLBACK (no_turbo_changed), pstate);
}
update_no_turbo (pstate);
}
update_no_turbo (pstate);
out:
g_debug ("%s p-state settings",

2
tests/integration-test.py
View file

@ -815,7 +815,7 @@ class Tests(dbusmock.DBusTestCase):
profiles = self.get_dbus_property('Profiles')
self.assertEqual(len(profiles), 3)
self.assertEqual(self.get_dbus_property('PerformanceDegraded'), 'high-operating-temperature')
self.assertEqual(self.get_dbus_property('PerformanceDegraded'), '')
self.stop_daemon()