fdo-mirrors/plymouth
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/plymouth/plymouth.git synced 2026-05-05 22:48:00 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

ply-device-manager: add a verify_add_or_change() helper

Browse source 
Add a verify_add_or_change() helper function. This is a preparation
patch for coalescing multiple change events on the same card together
to speed up probing of the drm connectors.

Note this causes the action == "add" || action == "change" check to
be done twice. This double checking goes away in the next patch.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
This commit is contained in:
Hans de Goede 2021-03-05 12:20:52 +01:00
parent a649b55108
commit dc8dc20b26
1 changed files with 28 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
src/libply-splash-core/ply-device-manager.c
View file

@ -400,6 +400,32 @@ on_drm_udev_add_or_change (ply_device_manager_t *manager,
}
}
static bool
verify_add_or_change (ply_device_manager_t *manager,
const char *action,
const char *device_path,
struct udev_device *device)
{
const char *subsystem = udev_device_get_subsystem (device);
if (strcmp (action, "add") && strcmp (action, "change"))
return false;
subsystem = udev_device_get_subsystem (device);
if (strcmp (subsystem, SUBSYSTEM_DRM) == 0) {
if (manager->local_console_managed && manager->local_console_is_text) {
ply_trace ("ignoring since we're already using text splash for local console");
return false;
}
} else {
ply_trace ("ignoring since we only handle subsystem %s devices after timeout", subsystem);
return false;
}
return true;
}
static void
on_udev_event (ply_device_manager_t *manager)
{
@ -420,18 +446,8 @@ on_udev_event (ply_device_manager_t *manager)
ply_trace ("got %s event for device %s", action, device_path);
if (strcmp (action, "add") == 0 || strcmp (action, "change") == 0) {
const char *subsystem;
subsystem = udev_device_get_subsystem (device);
if (strcmp (subsystem, SUBSYSTEM_DRM) == 0) {
if (manager->local_console_managed && manager->local_console_is_text)
ply_trace ("ignoring since we're already using text splash for local console");
else
on_drm_udev_add_or_change (manager, action, device_path, device);
} else {
ply_trace ("ignoring since we only handle subsystem %s devices after timeout", subsystem);
}
if (verify_add_or_change (manager, action, device_path, device))
on_drm_udev_add_or_change (manager, action, device_path, device);
} else if (strcmp (action, "remove") == 0) {
free_devices_from_device_path (manager, device_path, true);
}