fdo-mirrors/plymouth
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/plymouth/plymouth.git synced 2026-05-07 15:28:12 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

space-flares: Fix compiler warning

Browse source 
Recent gcc versions give the following compiler warning with space-flares:
./plugin.c: In function ‘star_bg_update’:
./plugin.c:762:21: warning: taking the absolute value of unsigned type ‘uint32_t’ {aka ‘unsigned int’} has no effect [-Wabsolute-value]
  762 |                 if (abs (((image_data[x + y * width] >> 16) & 0xff) - ((pixel_colour >> 16) & 0xff)) > 8) {
      |                     ^~~

This commit fixes this, assuming that gcc actually optimises the abs()
away, this will also make the code behave as intended again.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
This commit is contained in:
Hans de Goede 2019-09-30 11:12:45 +02:00
parent c7965ea19a
commit bf6ef0a481
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/plugins/splash/space-flares/plugin.c
View file

@ -759,7 +759,7 @@ star_bg_update (view_t *view, sprite_t *sprite, double time)
x = star_bg->star_x[i];
y = star_bg->star_y[i];
uint32_t pixel_colour = star_bg_gradient_colour (x, y, width, height, true, time);
if (abs (((image_data[x + y * width] >> 16) & 0xff) - ((pixel_colour >> 16) & 0xff)) > 8) {
if (abs ((int)((image_data[x + y * width] >> 16) & 0xff) - (int)((pixel_colour >> 16) & 0xff)) > 8) {
image_data[x + y * width] = pixel_colour;
star_bg->star_refresh[i] = 1;
}