fdo-mirrors/plymouth
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/plymouth/plymouth.git synced 2026-05-08 08:58:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

drm: Limit backend->resources lifetime to within query_device

Browse source 
We do not need / use backend->resources anywhere outside of the query_device
function and with the upcoming hotplug support we need to get a fresh set
of resources on change events, so limit the resources lifetime to
query_device.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
This commit is contained in:
Hans de Goede 2019-01-15 09:21:05 +01:00
parent d68fd78ae1
commit 7cb2eb1489
1 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/plugins/renderers/drm/plugin.c
View file

@ -838,8 +838,6 @@ destroy_backend (ply_renderer_backend_t *backend)
ply_hashtable_free (backend->output_buffers);
ply_hashtable_free (backend->heads_by_controller_id);
drmModeFreeResources (backend->resources);
free (backend->outputs);
free (backend);
}
@ -1385,6 +1383,8 @@ has_32bpp_support (ply_renderer_backend_t *backend)
static bool
query_device (ply_renderer_backend_t *backend)
{
bool ret = true;
assert (backend != NULL);
assert (backend->device_fd >= 0);
@ -1397,15 +1397,16 @@ query_device (ply_renderer_backend_t *backend)
if (!create_heads_for_active_connectors (backend)) {
ply_trace ("Could not initialize heads");
return false;
}
if (!has_32bpp_support (backend)) {
ret = false;
} else if (!has_32bpp_support (backend)) {
ply_trace ("Device doesn't support 32bpp framebuffer");
return false;
ret = false;
}
return true;
drmModeFreeResources (backend->resources);
backend->resources = NULL;
return ret;
}
static bool