fdo-mirrors/plymouth
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/plymouth/plymouth.git synced 2026-05-08 13:38:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

main: fix incorrectly sized buffer for /proc/cmdline

Browse source 
We assume /proc/cmdline will be no more than 512 bytes (including NUL).
It can actually be 4096 bytes (excluding NUL).

This commit makes sure we allocate enough space for it and its NUL.
This commit is contained in:
Ray Strode 2014-10-10 16:11:01 -04:00
parent 530612fb79
commit 5caf43a2c3
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/main.c
View file

@ -57,7 +57,7 @@
#include "ply-progress.h"
#ifndef PLY_MAX_COMMAND_LINE_SIZE
#define PLY_MAX_COMMAND_LINE_SIZE 512
#define PLY_MAX_COMMAND_LINE_SIZE 4097
#endif
#define BOOT_DURATION_FILE PLYMOUTH_TIME_DIRECTORY "/boot-duration"
@ -1703,7 +1703,7 @@ get_kernel_command_line (state_t *state)
}
ply_trace ("reading kernel command line");
if (read (fd, state->kernel_command_line, sizeof(state->kernel_command_line)) < 0) {
if (read (fd, state->kernel_command_line, sizeof(state->kernel_command_line) - 1) < 0) {
ply_trace ("couldn't read it: %m");
close (fd);
return false;