fdo-mirrors/plymouth
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/plymouth/plymouth.git synced 2026-05-08 12:28:12 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Revert "Make boot.log world readable by default"

Browse source 
This reverts commit fc5cd88767.

It's better to let the admin of the system decide the permissions,
than forcefully change them.
This commit is contained in:
Ray Strode 2017-05-11 10:52:30 -04:00
parent 6fd5c6b260
commit 1fa54b06c7
3 changed files with 5 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/libply/ply-logger.c
View file

@ -310,8 +310,7 @@ ply_logger_free (ply_logger_t *logger)
bool
ply_logger_open_file (ply_logger_t *logger,
const char *filename,
bool world_readable)
const char *filename)
{
int fd;
mode_t mode;
@ -319,21 +318,11 @@ ply_logger_open_file (ply_logger_t *logger,
assert (logger != NULL);
assert (filename != NULL);
if (world_readable)
mode = 0644;
else
mode = 0600;
fd = open (filename, PLY_LOGGER_OPEN_FLAGS, mode);
fd = open (filename, PLY_LOGGER_OPEN_FLAGS, 0600);
if (fd < 0)
return false;
if (fchmod (fd, mode) < 0) {
close (fd);
return false;
}
ply_logger_set_output_fd (logger, fd);
free (logger->filename);

5
src/libply/ply-logger.h
View file

@ -46,8 +46,7 @@ typedef void (*ply_logger_filter_handler_t) (void *user_data,
ply_logger_t *ply_logger_new (void);
void ply_logger_free (ply_logger_t *logger);
bool ply_logger_open_file (ply_logger_t *logger,
const char *filename,
bool world_readable);
const char *filename);
void ply_logger_close_file (ply_logger_t *logger);
void ply_logger_set_output_fd (ply_logger_t *logger,
int fd);
@ -108,7 +107,7 @@ bool ply_logger_is_tracing_enabled (ply_logger_t *logger);
/* convenience macros
*/
#define ply_open_log_file(filename) \
ply_logger_open_file (ply_logger_get_default (), filename, false)
ply_logger_open_file (ply_logger_get_default (), filename)
#define ply_close_log_file() \
ply_logger_close_file (ply_logger_get_default ())
#define ply_flush_log() \

2
src/libply/ply-terminal-session.c
View file

@ -555,7 +555,7 @@ ply_terminal_session_open_log (ply_terminal_session_t *session,
ply_save_errno ();
unlink (filename);
log_is_opened = ply_logger_open_file (session->logger, filename, true);
log_is_opened = ply_logger_open_file (session->logger, filename);
if (log_is_opened)
ply_logger_flush (session->logger);
ply_restore_errno ();