From edcecd897514bcaeca997f15165e8e951567b0b8 Mon Sep 17 00:00:00 2001 From: Sam James Date: Fri, 24 Jan 2025 06:15:05 +0000 Subject: [PATCH] meson.build: drop -Wno-error=strict-aliasing This was added in error (88873e295b02f279112e76a154681d98471c0ce5) but we discussed it in !2180 and it turned out CFLAGS="... -fstrict-aliasing" was set in the environment, overriding the earlier -fno-strict-aliasing already set in meson.build (which we're keeping here). That is, when -fno-strict-aliasing is in-effect, there's already no need for -Wno-error=strict-aliasing (as the warnings aren't emitted), but if there *is* a need for a -Wno-error=strict-aliasing for a user, it means they're (likely unintentionally) enabling strict-aliasing and we certainly want to make them aware of that. --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meson.build b/meson.build index bf7bc60ac..53e9d7b9c 100644 --- a/meson.build +++ b/meson.build @@ -81,7 +81,6 @@ pkgconfig = import('pkgconfig') common_flags = [ '-fvisibility=hidden', '-fno-strict-aliasing', - '-Wno-error=strict-aliasing', '-Werror=suggest-attribute=format', '-Wsign-compare', '-Wpointer-arith',