diff --git a/src/gst/gstpipewiresink.c b/src/gst/gstpipewiresink.c index dde1e85b7..9e07e09d7 100644 --- a/src/gst/gstpipewiresink.c +++ b/src/gst/gstpipewiresink.c @@ -584,6 +584,8 @@ gst_pipewire_sink_setcaps (GstBaseSink * bsink, GstCaps * caps) if (pwsink->target_object) { struct spa_dict_item items[2] = { SPA_DICT_ITEM_INIT(PW_KEY_TARGET_OBJECT, pwsink->target_object), + /* XXX deprecated but the portal and some example apps only + * provide the object id */ SPA_DICT_ITEM_INIT(PW_KEY_NODE_TARGET, NULL), }; struct spa_dict dict = SPA_DICT_INIT_ARRAY(items); diff --git a/src/gst/gstpipewiresrc.c b/src/gst/gstpipewiresrc.c index 760245c33..069991158 100644 --- a/src/gst/gstpipewiresrc.c +++ b/src/gst/gstpipewiresrc.c @@ -844,6 +844,8 @@ gst_pipewire_src_negotiate (GstBaseSrc * basesrc) if (pwsrc->target_object) { struct spa_dict_item items[2] = { SPA_DICT_ITEM_INIT(PW_KEY_TARGET_OBJECT, pwsrc->target_object), + /* XXX deprecated but the portal and some example apps only + * provide the object id */ SPA_DICT_ITEM_INIT(PW_KEY_NODE_TARGET, NULL), }; struct spa_dict dict = SPA_DICT_INIT_ARRAY(items); diff --git a/src/modules/module-client-node/v0/client-node.c b/src/modules/module-client-node/v0/client-node.c index 214c1bdfc..e70a7c2b1 100644 --- a/src/modules/module-client-node/v0/client-node.c +++ b/src/modules/module-client-node/v0/client-node.c @@ -1332,6 +1332,7 @@ static void convert_properties(struct pw_properties *properties) const char *from, *to; } props[] = { { "pipewire.autoconnect", PW_KEY_NODE_AUTOCONNECT, }, + /* XXX deprecated */ { "pipewire.target.node", PW_KEY_NODE_TARGET, } }; diff --git a/src/pipewire/stream.c b/src/pipewire/stream.c index de2ce09e8..6bd435db9 100644 --- a/src/pipewire/stream.c +++ b/src/pipewire/stream.c @@ -1892,7 +1892,7 @@ pw_stream_connect(struct pw_stream *stream, stream_set_state(stream, PW_STREAM_STATE_CONNECTING, NULL); if (target_id != PW_ID_ANY) - /* this is deprecated but still used by the portal and its apps */ + /* XXX this is deprecated but still used by the portal and its apps */ pw_properties_setf(stream->properties, PW_KEY_NODE_TARGET, "%d", target_id); else if ((str = getenv("PIPEWIRE_NODE")) != NULL) pw_properties_set(stream->properties, PW_KEY_TARGET_OBJECT, str);