From c5bce24f0143c2ec2fc3950888bee137366f86f4 Mon Sep 17 00:00:00 2001 From: Huang-Huang Bao Date: Sat, 23 Jul 2022 16:33:44 +0800 Subject: [PATCH] bluez5: correct type of arguments to a dbus function The 3rd "value" arguments to dbus_message_iter_append_basic() should be the address of a basic-typed value. Fixes #2591 --- spa/plugins/bluez5/bluez5-dbus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spa/plugins/bluez5/bluez5-dbus.c b/spa/plugins/bluez5/bluez5-dbus.c index e110efcde..f43d4b57d 100644 --- a/spa/plugins/bluez5/bluez5-dbus.c +++ b/spa/plugins/bluez5/bluez5-dbus.c @@ -3285,7 +3285,7 @@ static void bluez_register_endpoint_reply(DBusPendingCall *pending, void *user_d static void append_basic_variant_dict_entry(DBusMessageIter *dict, const char* key, int variant_type_int, const char* variant_type_str, void* variant) { DBusMessageIter dict_entry_it, variant_it; dbus_message_iter_open_container(dict, DBUS_TYPE_DICT_ENTRY, NULL, &dict_entry_it); - dbus_message_iter_append_basic(&dict_entry_it, DBUS_TYPE_STRING, key); + dbus_message_iter_append_basic(&dict_entry_it, DBUS_TYPE_STRING, &key); dbus_message_iter_open_container(&dict_entry_it, DBUS_TYPE_VARIANT, variant_type_str, &variant_it); dbus_message_iter_append_basic(&variant_it, variant_type_int, variant); @@ -3296,7 +3296,7 @@ static void append_basic_variant_dict_entry(DBusMessageIter *dict, const char* k static void append_basic_array_variant_dict_entry(DBusMessageIter *dict, const char* key, const char* variant_type_str, const char* array_type_str, int array_type_int, void* data, int data_size) { DBusMessageIter dict_entry_it, variant_it, array_it; dbus_message_iter_open_container(dict, DBUS_TYPE_DICT_ENTRY, NULL, &dict_entry_it); - dbus_message_iter_append_basic(&dict_entry_it, DBUS_TYPE_STRING, key); + dbus_message_iter_append_basic(&dict_entry_it, DBUS_TYPE_STRING, &key); dbus_message_iter_open_container(&dict_entry_it, DBUS_TYPE_VARIANT, variant_type_str, &variant_it); dbus_message_iter_open_container(&variant_it, DBUS_TYPE_ARRAY, array_type_str, &array_it);