From c4cd8fa73dd2bff806debc85c1c7589aec5e5fb1 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Thu, 23 Nov 2023 12:29:55 +0100 Subject: [PATCH] impl-client: don't log warning when updating ignored keys If a client tries to update an ignored key, don't log a warning. Only log a warning when one of the security properties changed. This is what we used to do before commit 0dfa05117bec16ee1817c3fa92f960a7d5e3b9b9 It fixes a warning when a stream disconnects and reconnects because the serial.id changed. --- src/pipewire/impl-client.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/pipewire/impl-client.c b/src/pipewire/impl-client.c index ae5a1b1f4..d5d865a6b 100644 --- a/src/pipewire/impl-client.c +++ b/src/pipewire/impl-client.c @@ -165,7 +165,7 @@ static bool check_client_property_update(struct pw_impl_client *client, /* Refuse specific restricted keys */ if (has_key(ignored, key)) - goto deny; + goto ignore; /* Refuse all security keys */ if (spa_strstartswith(key, "pipewire.sec.")) @@ -184,6 +184,7 @@ deny: if (!spa_streq(old, new)) pw_log_warn("%p: refuse property update '%s' from '%s' to '%s'", client, key, old ? old : "", new ? new : ""); +ignore: return false; }