From c362bca5e9d6dc1ea8804a33144b3aec09c40ce8 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Wed, 6 May 2026 16:07:59 +0200 Subject: [PATCH] loopback: handle stream setup failure Instead of silently failing. Also when we do the cleanup, make sure we don't free the props twice. --- src/modules/module-loopback.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/modules/module-loopback.c b/src/modules/module-loopback.c index 1075316b8..a6d41b909 100644 --- a/src/modules/module-loopback.c +++ b/src/modules/module-loopback.c @@ -1014,6 +1014,7 @@ int pipewire__module_init(struct pw_impl_module *module, const char *args) } pw_properties_free(props); + props = NULL; pw_proxy_add_listener((struct pw_proxy*)impl->core, &impl->core_proxy_listener, @@ -1022,7 +1023,8 @@ int pipewire__module_init(struct pw_impl_module *module, const char *args) &impl->core_listener, &core_events, impl); - setup_streams(impl); + if ((res = setup_streams(impl)) < 0) + goto error; pw_impl_module_add_listener(module, &impl->module_listener, &module_events, impl);