mirror of
https://gitlab.freedesktop.org/pulseaudio/pavucontrol.git
synced 2026-05-20 14:48:16 +02:00
b2362f2223
Widgets (unlike Windows and Dialogs) returned by Gtk::Builder::get_widget* start owned by the GtkBuilder object, the idea being that they will get added to a container before the scope of the GtkBuilder object ends, and it thus automatically gets destroyed. But in the various ::create methods in pavucontrol, a pointer to the widget gets returned, so that it can be added to a cointainer by the caller. However as soon as the ::create method exits the GtkBuilder object owning the widget, and thus also the widget gets destroyed, and we end up returning free-ed memory. This commit fixes this by making all ::create methods take a reference on the widget before returning it, and having all the callers unreference the widget after adding it to a container. https://bugs.freedesktop.org/show_bug.cgi?id=83144 https://bugzilla.redhat.com/show_bug.cgi?id=1133339 Signed-off-by: Hans de Goede <hdegoede@redhat.com>
145 lines
3.9 KiB
C++
145 lines
3.9 KiB
C++
/***
|
|
This file is part of pavucontrol.
|
|
|
|
Copyright 2006-2008 Lennart Poettering
|
|
Copyright 2009 Colin Guthrie
|
|
|
|
pavucontrol is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation, either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
pavucontrol is distributed in the hope that it will be useful, but
|
|
WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with pavucontrol. If not, see <http://www.gnu.org/licenses/>.
|
|
***/
|
|
|
|
#ifdef HAVE_CONFIG_H
|
|
#include <config.h>
|
|
#endif
|
|
|
|
#include "sinkinputwidget.h"
|
|
#include "mainwindow.h"
|
|
#include "sinkwidget.h"
|
|
|
|
#include "i18n.h"
|
|
|
|
SinkInputWidget::SinkInputWidget(BaseObjectType* cobject, const Glib::RefPtr<Gtk::Builder>& x) :
|
|
StreamWidget(cobject, x) {
|
|
|
|
gchar *txt;
|
|
directionLabel->set_label(txt = g_markup_printf_escaped("<i>%s</i>", _("on")));
|
|
g_free(txt);
|
|
|
|
terminate.set_label(_("Terminate Playback"));
|
|
}
|
|
|
|
SinkInputWidget* SinkInputWidget::create(MainWindow* mainWindow) {
|
|
SinkInputWidget* w;
|
|
Glib::RefPtr<Gtk::Builder> x = Gtk::Builder::create_from_file(GLADE_FILE, "streamWidget");
|
|
x->get_widget_derived("streamWidget", w);
|
|
w->init(mainWindow);
|
|
w->reference();
|
|
return w;
|
|
}
|
|
|
|
SinkInputWidget::~SinkInputWidget(void) {
|
|
clearMenu();
|
|
}
|
|
|
|
void SinkInputWidget::setSinkIndex(uint32_t idx) {
|
|
mSinkIndex = idx;
|
|
|
|
if (mpMainWindow->sinkWidgets.count(idx)) {
|
|
SinkWidget *w = mpMainWindow->sinkWidgets[idx];
|
|
deviceButton->set_label(w->description.c_str());
|
|
}
|
|
else
|
|
deviceButton->set_label(_("Unknown output"));
|
|
}
|
|
|
|
uint32_t SinkInputWidget::sinkIndex() {
|
|
return mSinkIndex;
|
|
}
|
|
|
|
void SinkInputWidget::executeVolumeUpdate() {
|
|
pa_operation* o;
|
|
|
|
if (!(o = pa_context_set_sink_input_volume(get_context(), index, &volume, NULL, NULL))) {
|
|
show_error(_("pa_context_set_sink_input_volume() failed"));
|
|
return;
|
|
}
|
|
|
|
pa_operation_unref(o);
|
|
}
|
|
|
|
void SinkInputWidget::onMuteToggleButton() {
|
|
StreamWidget::onMuteToggleButton();
|
|
|
|
if (updating)
|
|
return;
|
|
|
|
pa_operation* o;
|
|
if (!(o = pa_context_set_sink_input_mute(get_context(), index, muteToggleButton->get_active(), NULL, NULL))) {
|
|
show_error(_("pa_context_set_sink_input_mute() failed"));
|
|
return;
|
|
}
|
|
|
|
pa_operation_unref(o);
|
|
}
|
|
|
|
void SinkInputWidget::onKill() {
|
|
pa_operation* o;
|
|
if (!(o = pa_context_kill_sink_input(get_context(), index, NULL, NULL))) {
|
|
show_error(_("pa_context_kill_sink_input() failed"));
|
|
return;
|
|
}
|
|
|
|
pa_operation_unref(o);
|
|
}
|
|
|
|
void SinkInputWidget::clearMenu() {
|
|
while (!sinkMenuItems.empty()) {
|
|
std::map<uint32_t, SinkMenuItem*>::iterator i = sinkMenuItems.begin();
|
|
delete i->second;
|
|
sinkMenuItems.erase(i);
|
|
}
|
|
}
|
|
|
|
void SinkInputWidget::buildMenu() {
|
|
for (std::map<uint32_t, SinkWidget*>::iterator i = mpMainWindow->sinkWidgets.begin(); i != mpMainWindow->sinkWidgets.end(); ++i) {
|
|
SinkMenuItem *m;
|
|
sinkMenuItems[i->second->index] = m = new SinkMenuItem(this, i->second->description.c_str(), i->second->index, i->second->index == mSinkIndex);
|
|
menu.append(m->menuItem);
|
|
}
|
|
menu.show_all();
|
|
}
|
|
|
|
void SinkInputWidget::SinkMenuItem::onToggle() {
|
|
if (widget->updating)
|
|
return;
|
|
|
|
if (!menuItem.get_active())
|
|
return;
|
|
|
|
/*if (!mpMainWindow->sinkWidgets.count(widget->index))
|
|
return;*/
|
|
|
|
pa_operation* o;
|
|
if (!(o = pa_context_move_sink_input_by_index(get_context(), widget->index, index, NULL, NULL))) {
|
|
show_error(_("pa_context_move_sink_input_by_index() failed"));
|
|
return;
|
|
}
|
|
|
|
pa_operation_unref(o);
|
|
}
|
|
|
|
void SinkInputWidget::onDeviceChangePopup() {
|
|
clearMenu();
|
|
buildMenu();
|
|
menu.popup(1, 0);
|
|
}
|