mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-01-16 09:20:34 +01:00
I don't remember why I implemented it like this in !13959, but AFAICT there's no need to manually remove this queue from vk_device's queues list. On the other hand, this hack causes issues if syncobj timeline isn't supported; amdgpu always support timeline, but amdgpu over virtio-gpu doesn't. The issue is as follow: the sequence in vk_queue.c: case VK_QUEUE_SUBMIT_MODE_DEFERRED: vk_queue_push_submit(queue, submit); return vk_device_flush(queue->base.device); Would fail to produce the expected result, because vk_device_flush would fail to realize that the blit queue has some pending work because "vk_foreach_queue(queue, device)" would never process the queue. Then, the call to vk_drm_syncobj_export_sync_file() would fail, because the syncobj handle was never used in a submit. Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27412> |
||
|---|---|---|
| .. | ||
| addrlib | ||
| ci | ||
| common | ||
| compiler | ||
| drm-shim | ||
| llvm | ||
| registers | ||
| vpelib | ||
| vulkan | ||
| meson.build | ||