mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2025-12-23 13:20:14 +01:00
In the C23 standard unreachable() is now a predefined function-like macro in <stddef.h> See https://android.googlesource.com/platform/bionic/+/HEAD/docs/c23.md#is-now-a-predefined-function_like-macro-in And this causes build errors when building for C23: ----------------------------------------------------------------------- In file included from ../src/util/log.h:30, from ../src/util/log.c:30: ../src/util/macros.h:123:9: warning: "unreachable" redefined 123 | #define unreachable(str) \ | ^~~~~~~~~~~ In file included from ../src/util/macros.h:31: /usr/lib/gcc/x86_64-linux-gnu/14/include/stddef.h:456:9: note: this is the location of the previous definition 456 | #define unreachable() (__builtin_unreachable ()) | ^~~~~~~~~~~ ----------------------------------------------------------------------- So don't redefine it with the same name, but use the name UNREACHABLE() to also signify it's a macro. Using a different name also makes sense because the behavior of the macro was extending the one of __builtin_unreachable() anyway, and it also had a different signature, accepting one argument, compared to the standard unreachable() with no arguments. This change improves the chances of building mesa with the C23 standard, which for instance is the default in recent AOSP versions. All the instances of the macro, including the definition, were updated with the following command line: git grep -l '[^_]unreachable(' -- "src/**" | sort | uniq | \ while read file; \ do \ sed -e 's/\([^_]\)unreachable(/\1UNREACHABLE(/g' -i "$file"; \ done && \ sed -e 's/#undef unreachable/#undef UNREACHABLE/g' -i src/intel/isl/isl_aux_info.c Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36437>
274 lines
8.4 KiB
C++
274 lines
8.4 KiB
C++
/*
|
|
* Copyright © 2021 Intel Corporation
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*/
|
|
|
|
#include "brw_private.h"
|
|
#include "compiler/shader_info.h"
|
|
#include "intel/dev/intel_debug.h"
|
|
#include "intel/dev/intel_device_info.h"
|
|
#include "util/ralloc.h"
|
|
|
|
unsigned
|
|
brw_required_dispatch_width(const struct shader_info *info)
|
|
{
|
|
if ((int)info->subgroup_size >= (int)SUBGROUP_SIZE_REQUIRE_8) {
|
|
/* These enum values are expressly chosen to be equal to the subgroup
|
|
* size that they require.
|
|
*/
|
|
return (unsigned)info->subgroup_size;
|
|
} else {
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
unsigned
|
|
brw_geometry_stage_dispatch_width(const struct intel_device_info *devinfo)
|
|
{
|
|
if (devinfo->ver >= 20)
|
|
return 16;
|
|
return 8;
|
|
}
|
|
|
|
static inline bool
|
|
test_bit(unsigned mask, unsigned bit) {
|
|
return mask & (1u << bit);
|
|
}
|
|
|
|
namespace {
|
|
|
|
struct brw_cs_prog_data *
|
|
get_cs_prog_data(brw_simd_selection_state &state)
|
|
{
|
|
if (std::holds_alternative<struct brw_cs_prog_data *>(state.prog_data))
|
|
return std::get<struct brw_cs_prog_data *>(state.prog_data);
|
|
else
|
|
return nullptr;
|
|
}
|
|
|
|
struct brw_stage_prog_data *
|
|
get_prog_data(brw_simd_selection_state &state)
|
|
{
|
|
if (std::holds_alternative<struct brw_cs_prog_data *>(state.prog_data))
|
|
return &std::get<struct brw_cs_prog_data *>(state.prog_data)->base;
|
|
else if (std::holds_alternative<struct brw_bs_prog_data *>(state.prog_data))
|
|
return &std::get<struct brw_bs_prog_data *>(state.prog_data)->base;
|
|
else
|
|
return nullptr;
|
|
}
|
|
|
|
}
|
|
|
|
bool
|
|
brw_simd_should_compile(brw_simd_selection_state &state, unsigned simd)
|
|
{
|
|
assert(simd < SIMD_COUNT);
|
|
assert(!state.compiled[simd]);
|
|
|
|
const auto cs_prog_data = get_cs_prog_data(state);
|
|
const auto prog_data = get_prog_data(state);
|
|
const unsigned width = 8u << simd;
|
|
|
|
if (state.required_width && state.required_width != width) {
|
|
state.error[simd] = "Different than required dispatch width";
|
|
return false;
|
|
}
|
|
|
|
/* For shaders with variable size workgroup, in most cases we can compile
|
|
* all the variants (exceptions are bindless dispatch & ray queries), since
|
|
* the choice will happen only at dispatch time.
|
|
*/
|
|
const bool workgroup_size_variable = cs_prog_data && cs_prog_data->local_size[0] == 0;
|
|
|
|
if (!workgroup_size_variable && !state.required_width) {
|
|
if (state.spilled[simd]) {
|
|
state.error[simd] = "Would spill";
|
|
return false;
|
|
}
|
|
|
|
if (cs_prog_data) {
|
|
const unsigned workgroup_size = cs_prog_data->local_size[0] *
|
|
cs_prog_data->local_size[1] *
|
|
cs_prog_data->local_size[2];
|
|
|
|
unsigned max_threads = state.devinfo->max_cs_workgroup_threads;
|
|
|
|
const unsigned min_simd = state.devinfo->ver >= 20 ? 1 : 0;
|
|
if (simd > min_simd && workgroup_size <= (width / 2)) {
|
|
state.error[simd] = "Workgroup size already fits in smaller SIMD";
|
|
return false;
|
|
}
|
|
|
|
if (DIV_ROUND_UP(workgroup_size, width) > max_threads) {
|
|
state.error[simd] = "Would need more than max_threads to fit all invocations";
|
|
return false;
|
|
}
|
|
}
|
|
|
|
/* The SIMD32 is only enabled for cases it is needed unless forced.
|
|
*
|
|
* TODO: Use performance_analysis and drop this rule.
|
|
*/
|
|
if (width == 32 && state.devinfo->ver < 20) {
|
|
if (!INTEL_DEBUG(DEBUG_DO32) && (state.compiled[0] || state.compiled[1])) {
|
|
state.error[simd] = "SIMD32 not required (use INTEL_DEBUG=do32 to force)";
|
|
return false;
|
|
}
|
|
}
|
|
}
|
|
|
|
if (width == 8 && state.devinfo->ver >= 20) {
|
|
state.error[simd] = "SIMD8 not supported on Xe2+";
|
|
return false;
|
|
}
|
|
|
|
if (width == 32 && cs_prog_data && cs_prog_data->base.ray_queries > 0) {
|
|
state.error[simd] = "Ray queries not supported";
|
|
return false;
|
|
}
|
|
|
|
if (width == 32 && cs_prog_data && cs_prog_data->uses_btd_stack_ids) {
|
|
state.error[simd] = "Bindless shader calls not supported";
|
|
return false;
|
|
}
|
|
|
|
uint64_t start;
|
|
switch (prog_data->stage) {
|
|
case MESA_SHADER_COMPUTE:
|
|
start = DEBUG_CS_SIMD8;
|
|
break;
|
|
case MESA_SHADER_TASK:
|
|
start = DEBUG_TS_SIMD8;
|
|
break;
|
|
case MESA_SHADER_MESH:
|
|
start = DEBUG_MS_SIMD8;
|
|
break;
|
|
case MESA_SHADER_RAYGEN:
|
|
case MESA_SHADER_ANY_HIT:
|
|
case MESA_SHADER_CLOSEST_HIT:
|
|
case MESA_SHADER_MISS:
|
|
case MESA_SHADER_INTERSECTION:
|
|
case MESA_SHADER_CALLABLE:
|
|
start = DEBUG_RT_SIMD8;
|
|
break;
|
|
default:
|
|
UNREACHABLE("unknown shader stage in brw_simd_should_compile");
|
|
}
|
|
|
|
const bool env_skip[] = {
|
|
(intel_simd & (start << 0)) == 0,
|
|
(intel_simd & (start << 1)) == 0,
|
|
(intel_simd & (start << 2)) == 0,
|
|
};
|
|
|
|
static_assert(ARRAY_SIZE(env_skip) == SIMD_COUNT);
|
|
|
|
if (unlikely(env_skip[simd])) {
|
|
state.error[simd] = "Disabled by INTEL_DEBUG environment variable";
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
void
|
|
brw_simd_mark_compiled(brw_simd_selection_state &state, unsigned simd, bool spilled)
|
|
{
|
|
assert(simd < SIMD_COUNT);
|
|
assert(!state.compiled[simd]);
|
|
|
|
auto cs_prog_data = get_cs_prog_data(state);
|
|
|
|
state.compiled[simd] = true;
|
|
if (cs_prog_data)
|
|
cs_prog_data->prog_mask |= 1u << simd;
|
|
|
|
/* If a SIMD spilled, all the larger ones would spill too. */
|
|
if (spilled) {
|
|
for (unsigned i = simd; i < SIMD_COUNT; i++) {
|
|
state.spilled[i] = true;
|
|
if (cs_prog_data)
|
|
cs_prog_data->prog_spilled |= 1u << i;
|
|
}
|
|
}
|
|
}
|
|
|
|
int
|
|
brw_simd_select(const struct brw_simd_selection_state &state)
|
|
{
|
|
for (int i = SIMD_COUNT - 1; i >= 0; i--) {
|
|
if (state.compiled[i] && !state.spilled[i])
|
|
return i;
|
|
}
|
|
for (int i = SIMD_COUNT - 1; i >= 0; i--) {
|
|
if (state.compiled[i])
|
|
return i;
|
|
}
|
|
return -1;
|
|
}
|
|
|
|
int
|
|
brw_simd_select_for_workgroup_size(const struct intel_device_info *devinfo,
|
|
const struct brw_cs_prog_data *prog_data,
|
|
const unsigned *sizes)
|
|
{
|
|
if (!sizes || (prog_data->local_size[0] == sizes[0] &&
|
|
prog_data->local_size[1] == sizes[1] &&
|
|
prog_data->local_size[2] == sizes[2])) {
|
|
brw_simd_selection_state simd_state{
|
|
.prog_data = const_cast<struct brw_cs_prog_data *>(prog_data),
|
|
};
|
|
|
|
/* Propagate the prog_data information back to the simd_state,
|
|
* so we can use select() directly.
|
|
*/
|
|
for (int i = 0; i < SIMD_COUNT; i++) {
|
|
simd_state.compiled[i] = test_bit(prog_data->prog_mask, i);
|
|
simd_state.spilled[i] = test_bit(prog_data->prog_spilled, i);
|
|
}
|
|
|
|
return brw_simd_select(simd_state);
|
|
}
|
|
|
|
struct brw_cs_prog_data cloned = *prog_data;
|
|
for (unsigned i = 0; i < 3; i++)
|
|
cloned.local_size[i] = sizes[i];
|
|
|
|
cloned.prog_mask = 0;
|
|
cloned.prog_spilled = 0;
|
|
|
|
brw_simd_selection_state simd_state{
|
|
.devinfo = devinfo,
|
|
.prog_data = &cloned,
|
|
};
|
|
|
|
for (unsigned simd = 0; simd < SIMD_COUNT; simd++) {
|
|
/* We are not recompiling, so use original results of prog_mask and
|
|
* prog_spilled as they will already contain all possible compilations.
|
|
*/
|
|
if (brw_simd_should_compile(simd_state, simd) &&
|
|
test_bit(prog_data->prog_mask, simd)) {
|
|
brw_simd_mark_compiled(simd_state, simd, test_bit(prog_data->prog_spilled, simd));
|
|
}
|
|
}
|
|
|
|
return brw_simd_select(simd_state);
|
|
}
|